chore(jmc-core): update to JMC version 9.0.0 #427
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
needs-triage
andrewazores
added
dependencies
|
/build_test |
|
Workflow started at 5/1/2024, 2:30:50 PM. View Actions Run. |
|
No OpenAPI schema changes detected. |
|
No GraphQL schema changes detected. |
|
CI build and push: All tests pass ✅ (JDK17) |
andrewazores
reviewed
May 1, 2024
There was a problem hiding this comment.
Change looks good, PR CI passes, manual build and test locally looks good.
Let's wait for cryostatio/cryostat-reports#234 to go in so I can trigger a manual build there and make sure the main CI builds it without issue (I can't see why it would, but you never know with this infrastructure). Once that's seen then we can proceed to mirror the changes for cryostat3 and jfr-datasource.
andrewazores
approved these changes
May 2, 2024
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Welcome to Cryostat3! 👋
Before contributing, make sure you have:
mainbranch[chore, ci, docs, feat, fix, test]To recreate commits with GPG signature
git fetch upstream && git rebase --force --gpg-sign upstream/mainFixes: # cryostatio/cryostat-core#173, #59, cryostatio/cryostat-core#22
Relates to cryostatio/cryostat-core#362 and cryostatio/cryostat-reports#233
Description of the change:
This PR adds two repositories to the pom; one that allows for using the cryostat-core 3.0.0-SNAPSHOT for builds, and the other that pulls in the jmc core 9.0.0 libs from Adoptium. There are also a handful of import changes around the codebase to accommodate the new jmc core structure.
Motivation for the change:
Allows for using a cryostat-core that consumes all JMC dependencies from an available vendor instead of maintaining a separate copy of the classes.
How to manually test: