refactor(auto-rules): Periodic archiver should not use http req to self #557
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jan-law
changed the title
|
@hareetd the RecordingHelper change sounds very similar to what we were discussing for your PR draft.
|
jan-law
changed the title
jan-law
changed the title
|
How do I add a release type to this pull request? |
|
The PR title has to follow the format:verb(area): some messageI think the check here failed because the colon is missing.
|
jan-law
changed the title
|
@andrewazores Yeah, it does. I'll try to make the changes in my PR stay logically consistent with what @jan-law has done in the |
andrewazores
reviewed
Jul 7, 2021
andrewazores
reviewed
Jul 7, 2021
andrewazores
reviewed
Jul 7, 2021
andrewazores
reviewed
Jul 7, 2021
andrewazores
reviewed
Jul 7, 2021
andrewazores
previously approved these changes
Jul 7, 2021
andrewazores
dismissed
their stale review
Meant to just leave feedback, not approve (yet)
jan-law
force-pushed
the
PeriodicArchiver-should-not-use-http-req-to-self
branch
from
3344448
to
6003262
Compare
added 9 commits
July 8, 2021 10:08
jan-law
force-pushed
the
PeriodicArchiver-should-not-use-http-req-to-self
branch
from
751a193
to
a0323f2
Compare
andrewazores
reviewed
Jul 8, 2021
andrewazores
reviewed
Jul 8, 2021
andrewazores
approved these changes
Jul 8, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #543
I renamed
recordingCreationHelpertorecordingHelperas it now contains helper functions to save and delete recordings. These helper functions are used in bothPeriodicArchiver.javaandTargetRecordingPatchSave.java.