fix(snapshot): do not issue a Recording Deleted notification when empty snapshots are deleted

[hareetd]

Fixes #911

[andrewazores]

Change looks good. I think there's another half to this problem though. If I make an API request to create a snapshot recording, and that snapshot ends up being empty, then this prevents a notification from being emitted when that snapshot is automatically deleted due to being detected as empty. But I'm still going to receive a notification that the recording was created, right? However, when I go looking in the active recordings list for that recording, I won't find it there. The web-client that uses notifications to update state might also create a UI entry representing the snapshot based on that notification and then not automatically remove it since there is no corresponding deletion notification.

[hareetd]

We're good on that end, the backend doesn't actually issue any notifications when creating snapshot recordings. Instead, the frontend is doing the notification handling in ApiService#createSnapshot, where a Recording Creation snapshot is only issued if the backend response is a 200, meaning the snapshot was created and passed verification.

It's been a while so I don't remember why I decided to do it this way, I could move the notification handling to the backend to make it more consistent with how notifications are handled for other recording-related actions?

[andrewazores]

Oh, interesting. Yes I think that would be a good enhancement as well to bring that behaviour in line with everything else. I'll approve and merge this one on its own for now, but please file an issue for that.