Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test(itest): add tests for bad targetIds #932

Merged
merged 3 commits into from
May 12, 2022
Merged

test(itest): add tests for bad targetIds #932

merged 3 commits into from
May 12, 2022

Conversation

andrewazores
Copy link
Member

Related to #927

  • test(itest): add test for nonexistent targets
  • test(itest): add test for connecting to wrong target port

Adds two tests.

  1. Test what happens when querying active recordings on a targetId where the service URL has a nonexistent (not reachable) host
  2. Test what happens when querying active recordings on a targetId where the service URL points to a real reachable host and port, but the port is not listening for JMX connections, rather HTTP connections

@andrewazores andrewazores merged commit 0484b2f into cryostatio:main May 12, 2022
@andrewazores andrewazores deleted the test-bad-connections branch May 12, 2022 22:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hareetd hareetd hareetd approved these changes

@jan-law jan-law jan-law approved these changes

Assignees
No one assigned
Labels
test
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@andrewazores @hareetd @jan-law