Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(api): Move Probe handlers from beta to v2 package #956

Merged
merged 4 commits into from
May 26, 2022
Merged

chore(api): Move Probe handlers from beta to v2 package #956

merged 4 commits into from
May 26, 2022

Conversation

tthvo
Copy link
Member

@tthvo tthvo commented May 25, 2022 •
edited

Fixes #928

Move Probe handlers from beta to v2 sub-package since they are available in v2 API. This includes moving source and test files.

@tthvo tthvo added the chore Refactor, rename, cleanup, etc. label May 25, 2022
@tthvo tthvo requested a review from andrewazores May 25, 2022 15:45
@andrewazores
Copy link
Member

CI failed due to formatting lint rules. mvn spotless:apply should take care of it.

@tthvo
Copy link
Member Author

tthvo commented May 25, 2022

CI build failure looks like it runs into #666.

1371-2022-05-25T17:48:33.9875229Z [INFO] Running itest.ArchivedReportJwtDownloadIT
1372-2022-05-25T17:48:45.7598010Z [ERROR] Tests run: 1, Failures: 0, Errors: 1, Skipped: 0, Time elapsed: 11.77 s <<< FAILURE! - in itest.ArchivedReportJwtDownloadIT
1373-2022-05-25T17:48:45.7599320Z [ERROR] testDownloadRecordingUsingJwt  Time elapsed: 11.769 s  <<< ERROR!
1374-2022-05-25T17:48:45.7599780Z java.util.concurrent.ExecutionException: java.lang.Exception: HTTP 500
1375:2022-05-25T17:48:45.7600374Z 	at itest.ArchivedReportJwtDownloadIT.testDownloadRecordingUsingJwt(ArchivedReportJwtDownloadIT.java:78)
1376-2022-05-25T17:48:45.7601033Z Caused by: java.lang.Exception: HTTP 500

@andrewazores andrewazores merged commit 1eea5e0 into cryostatio:main May 26, 2022
@tthvo tthvo deleted the probe-handlers-v2-move branch May 30, 2022 15:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andrewazores andrewazores andrewazores approved these changes

Assignees
No one assigned
Labels
chore Refactor, rename, cleanup, etc.
Projects
No open projects
2.2.0 Release
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Task] JMC Agent Probe handlers are in V2 API version but 'beta' package
2 participants
@tthvo @andrewazores