fix(recordings): empty archive directories are now removed

[maxcao13]

Fixes #951

There is a bug that is tracked with the spotbugs bug tracker

[ERROR] Medium: Nullcheck of entries at line 242 of value previously dereferenced in io.cryostat.recordings.RecordingArchiveHelper.pathIsEmpty(Path) [io.cryostat.recordings.RecordingArchiveHelper, io.cryostat.recordings.RecordingArchiveHelper] At RecordingArchiveHelper.java:[line 242]Redundant null check at RecordingArchiveHelper.java:[line 243] RCN_REDUNDANT_NULLCHECK_WOULD_HAVE_BEEN_A_NPE

I'm not sure why because I don't see a clear null checking in the code I added.

[andrewazores]

There is a bug that is tracked with the spotbugs bug tracker

[ERROR] Medium: Nullcheck of entries at line 242 of value previously dereferenced in io.cryostat.recordings.RecordingArchiveHelper.pathIsEmpty(Path) [io.cryostat.recordings.RecordingArchiveHelper, io.cryostat.recordings.RecordingArchiveHelper] At RecordingArchiveHelper.java:[line 242]Redundant null check at RecordingArchiveHelper.java:[line 243] RCN_REDUNDANT_NULLCHECK_WOULD_HAVE_BEEN_A_NPE

I'm not sure why because I don't see a clear null checking in the code I added.

Ah, yea. I've seen this before. IIRC SpotBugs is doing its analysis on the compiled bytecode, not directly on the Java source code you wrote. The try-with-resources construct gets compiled down to bytecode that performs a null check and so SpotBugs sometimes flags that as redundant. I thought we had got around that by updating our SpotBugs version at some point, but maybe not.

spotbugs/spotbugs#756

You can just add a @SuppressFBWarnings annotation to ignore the false positive. Example:

cryostat/src/main/java/io/cryostat/net/web/WebServer.java

Line 258 in 5ebf150

@SuppressFBWarnings(

[maxcao13]

running mvn clean verify on my laptop builds and passes all tests fine, i've run git status and git log and nothing seems wrong there...

[andrewazores]

Looks like just a flakey test run. Those reports-related integration tests are usually the most problematic ones.