upgrade bootstrap and react-bootstrap to latest, update site components #313
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jimmcgaw
force-pushed
the
upgrade_bootstrap
branch
from
7e35b85
to
767cd03
Compare
|
Nice! There have been a couple remaining old dependencies and this should help a bunch with that. |
|
These larger fonts look fantastic btw |
elimisteve
reviewed
Feb 28, 2023
jimmcgaw
force-pushed
the
upgrade_bootstrap
branch
from
767cd03
to
2500c40
Compare
jimmcgaw
commented
Feb 28, 2023
jimmcgaw
commented
Feb 28, 2023
jimmcgaw
force-pushed
the
upgrade_bootstrap
branch
from
6552cc3
to
9f02d37
Compare
jimmcgaw
commented
Feb 28, 2023
|
@jimmcgaw Looks like use of EDIT: No I just checked out the wrong branch locally without running |
* LeapChat: Info button/icon: size={25} -> 19 (to match Username Edit button/icon)
* react-bootstrap upgrade: Make all modals size="lg", not the smaller default
* CSS: Make .icon-button global so it applies to modals, too
* FaCog: size={30} -> 27, plus `margin-top: 3px` to keep alignment
elimisteve
approved these changes
Feb 28, 2023
jimmcgaw
force-pushed
the
upgrade_bootstrap
branch
from
fe5b1c9
to
362d35a
Compare
|
@jimmcgaw Ready to merge? LGTM |
|
Dooo iiit |
|
🐎 🐎 🐎 🐎 🐎 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.