restore reconnect from observable flow #322
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Tested this locally; works great. Merging for now; we can merge a future version of |
jimmcgaw
reviewed
Mar 1, 2023
|
|
||
| reader.readAsText(fileBlob); | ||
| }); | ||
|
|
There was a problem hiding this comment.
Would you mind undoing all of the changes in this file? Was experimenting after a quick fix, so this is junk I'd rather not merge in.
There was a problem hiding this comment.
Is #321 better than this branch now?
There was a problem hiding this comment.
Checking... That's the branch you'd rather get merged, yes?
There was a problem hiding this comment.
In the other branch I'm getting
ERROR in ./src/utils/sessions.js 7:0-54
Module not found: Error: Can't resolve '../actions/chatActions' in '/home/user/gocode/src/github.com/cryptag/leapchat/src/utils'
resolve '../actions/chatActions' in '/home/user/gocode/src/github.com/cryptag/leapchat/src/utils'
using description file: /home/user/gocode/src/github.com/cryptag/leapchat/package.json (relative path: ./src/utils)
|
See #321 (comment) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Good work, @jimmcgaw