Merge pull request #4 from radiovisual/fetch

Replace popsicle with isomorphic-fetch

cli.js

@@ -26,9 +26,7 @@ const cli = meow(`
       USD: 261.91
 `);
 
-const input = cli.input.map(item => item.replace(/,|\s+/g, '')).join(',');
-
-ethPrice(input)
+ethPrice(cli.input.join(','))
 	.then(prices => {
 		spinner.stop();
 		prices.forEach(price => console.log(price));

index.js

@@ -1,23 +1,16 @@
 'use strict';
-const popsicle = require('popsicle');
+const fetch = require('isomorphic-fetch');
 
 module.exports = toSymbol => {
+	let symbols = 'USD';
 	if (typeof toSymbol === 'string') {
-		toSymbol = toSymbol.toUpperCase();
-	} else {
-		toSymbol = 'USD';
+		symbols = toSymbol.split(',').map(s => s.toUpperCase().replace(/\s+/g, '')).join(',');
 	}
 
-	return popsicle.request({
-		method: 'POST',
-		url: 'https://min-api.cryptocompare.com/data/price',
-		query: {
-			fsym: 'ETH',
-			tsyms: toSymbol
-		}
-	})
-		.use(popsicle.plugins.parse(['json']))
-		.then(resp => resp.body)
+	const url = `https://min-api.cryptocompare.com/data/price?fsym=ETH&tsyms=${symbols}`;
+
+	return fetch(url)
+		.then(resp => resp.json())
 		.then(data => {
 			const symbols = Object.keys(data);
 

package.json

@@ -27,9 +27,9 @@
 		"cryptocurrency"
 	],
 	"dependencies": {
+		"isomorphic-fetch": "^2.2.1",
 		"meow": "^3.7.0",
-		"ora": "^1.2.0",
-		"popsicle": "^9.1.0"
+		"ora": "^1.2.0"
 	},
 	"devDependencies": {
 		"ava": "^0.17.0",

test.js → test/currencies.js

@@ -1,12 +1,13 @@
 import test from 'ava';
 import nock from 'nock';
-import fn from '.';
+import fn from '../';
 
 const apiMock = nock('https://min-api.cryptocompare.com/data')
+	.persist()
 	.defaultReplyHeaders({
 		'Content-Type': 'application/json'
 	})
-	.post('/price');
+	.get('/price');
 
 apiMock
 	.query({
@@ -26,7 +27,7 @@ test('Get prices in format', async t => {
 test('Forgives whitespace in currency list', async t => {
 	t.plan(2);
 
-	const prices = await fn('usd,     btc');
+	const prices = await fn('usd,  btc');
 	t.is(prices[0], 'USD: 260.21');
 	t.is(prices[1], 'BTC: 0.0973');
 });

test/default.js

@@ -0,0 +1,24 @@
+import test from 'ava';
+import nock from 'nock';
+import fn from '../';
+
+const apiMock = nock('https://min-api.cryptocompare.com/data')
+	.persist()
+	.defaultReplyHeaders({
+		'Content-Type': 'application/json'
+	})
+	.get('/price');
+
+apiMock
+	.query({
+		fsym: 'ETH',
+		tsyms: 'USD'
+	})
+    .reply(200, '{"USD": 330.21}');
+
+test('Defaults to USD', async t => {
+	t.plan(1);
+
+	const prices = await fn();
+	t.is(prices[0], 'USD: 330.21');
+});