Feature/frontend integration #136
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
this-kramer
reviewed
Jul 19, 2022
web/src/router/index.js
Outdated
| @@ -1,12 +1,15 @@ | |||
| import {createRouter, createWebHashHistory} from 'vue-router'; | |||
|
|
|||
| import DsProtMain from '../components/dsprot/DsProtMain.vue' | |||
There was a problem hiding this comment.
Suggested change
| import DsProtMain from '../components/dsprot/DsProtMain.vue' | |
| const DsProtMain = () => import("@/components/dsprot/DsProtMain.vue") |
I think it's nicer to stick to lazy loading routes :)
There was a problem hiding this comment.
Seems to work, changed in next commit. What exactly is the benefit here?
this-kramer
reviewed
Jul 19, 2022
this-kramer
reviewed
Jul 19, 2022
this-kramer
approved these changes
Jul 19, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reason for this PR:
Note that the dsprotection service frontend can currently only run in dev mode, need to configure URL for dsprotection service backend for the production mode.
Checklist:
Select whatever applies: