Refactoring and adjusting to new ledger-tm library #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
+ Adding a basic command line
jleni
force-pushed
the
zondax/ledger-tm
branch
from
1e73d2f
to
99b5b27
Compare
adrianbrink
reviewed
Feb 15, 2019
Cargo.toml
Outdated
|
|
||
| # Enable integer overflow checks in release builds for security reasons | ||
| [profile.release] | ||
| overflow-checks = true | ||
|
|
||
| [patch.crates-io] |
There was a problem hiding this comment.
Could you push this into a public repo so that everyone can easily build the public version of the KMS.
Otherwise this looks good and ready to merge.
There was a problem hiding this comment.
yes, I had actually done that already :)
forgot to push that too. Ready now
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There aren't big changes here but we were working in parallel and now it is easier to be aligned.