Problem: missing feature of staking delegate in Cosmos SDK (fix #86) #118
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stevenatcrypto
requested review from
tomtau,
leejw51crypto,
SHH-HaoZhang and
damoncro
tomtau
approved these changes
Jan 26, 2022
| let msg = MsgUndelegate { | ||
| delegator_address: sender_address, | ||
| validator_address, | ||
| /// FIXME: amount should not support value of None |
There was a problem hiding this comment.
maybe None is to undelegate all?
There was a problem hiding this comment.
I tried to find the protocol and document in Cosmos SDK, it seems the amount cannot be null value 😂 (in below links).
https://github.com/cosmos/cosmos-sdk/blob/master/x/staking/spec/03_messages.md#msgundelegate
https://github.com/cosmos/cosmos-sdk/blob/v0.40.0/proto/cosmos/staking/v1beta1/tx.proto#L112-L121
https://crypto.org/docs/resources/cosmos-grpc-docs.html#cosmos.staking.v1beta1.MsgUndelegate
There was a problem hiding this comment.
I could not confirm for that. Just post a issue in cosmos-rust cosmos/cosmos-rust#174
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Close #86
Add message
MsgDelegateandMsgUndelegatefor Cosmos SDK.Has not find a good method to test. Will follow the integration-test task to find if it is easy to test, and add code for example.