Skip to content
This repository has been archived by the owner on Jul 27, 2022. It is now read-only.

Problem: "deposit amount" fee calculation is not correct #949

Closed
linfeng-crypto opened this issue Jan 21, 2020 · 1 comment
Closed

Problem: "deposit amount" fee calculation is not correct #949

linfeng-crypto opened this issue Jan 21, 2020 · 1 comment
Assignees
@yihuang @tomtau @calvinaco @devashishdxt @leejw51crypto
Labels
bug Something isn't working
Milestone
CRO Sprint 24

Comments

@linfeng-crypto
Copy link
Contributor

linfeng-crypto commented Jan 21, 2020 •
edited by tomtau

start tendermint with fee, deposit 500000, but get 500074.

deposited amount in the staked state is larger than what's specified in the command line.

the likely cause is dummysigner estimation
@tomtau tomtau changed the title deposit_amount fee calculation is not correct Problem: deposit_amount fee calculation is not correct Jan 21, 2020
@tomtau
Copy link
Contributor

tomtau commented Jan 21, 2020

not sure if related to #846

@tomtau tomtau added this to the CRO Sprint 23 milestone Jan 22, 2020
@tomtau tomtau added the bug Something isn't working label Jan 22, 2020
@tomtau tomtau changed the title Problem: deposit_amount fee calculation is not correct Problem: deposit tx amount fee calculation is not correct Jan 22, 2020
@tomtau tomtau changed the title Problem: deposit tx amount fee calculation is not correct Problem: "deposit amount" fee calculation is not correct Jan 22, 2020
@tomtau tomtau modified the milestones: CRO Sprint 23, CRO Sprint 24 Feb 12, 2020
yihuang added a commit to yihuang/chain that referenced this issue Feb 21, 2020
@yihuang
Problem (Fix crypto-com#949): deposit amount fee calculation is not c…
c7592e3 
…orrect

Solution:
- Fix DummySigner for deposit transaction
- Fix mock_enc_dec payload padding
yihuang added a commit to yihuang/chain that referenced this issue Feb 21, 2020
@yihuang
Problem (Fix crypto-com#949): deposit amount fee calculation is not c…
5c8d989 
…orrect

Solution:
- Fix DummySigner for deposit transaction
- Fix mock_enc_dec payload padding
yihuang added a commit to yihuang/chain that referenced this issue Feb 22, 2020
@yihuang
Problem (Fix crypto-com#949): deposit amount fee calculation is not c…
bfd5121 
…orrect

Solution:
- Fix DummySigner for deposit transaction
- Fix mock_enc_dec payload padding
- Test withdraw with viewkeys in the multinode join test (Fix crypto-com#1101)
yihuang added a commit to yihuang/chain that referenced this issue Feb 22, 2020
@yihuang
Problem (Fix crypto-com#949): deposit amount fee calculation is not c…
c28a50f 
…orrect

Solution:
- Fix DummySigner for deposit transaction
- Fix mock_enc_dec payload padding
- Test withdraw with viewkeys in the multinode join test (Fix crypto-com#1101)
bors bot added a commit that referenced this issue Feb 24, 2020
@bors @yihuang
Merge #1118
18eafc2 
1118: Problem (Fix #949): deposit amount fee calculation is not correct r=tomtau a=yihuang

Solution:
- Fix DummySigner for deposit transaction
- Fix mock_enc_dec payload padding
- Test withdraw with viewkeys in the multinode join test (Fix #1101  )

Co-authored-by: yihuang <huang@crypto.com>
@bors bors bot closed this as completed in a343137 Feb 24, 2020
tomtau pushed a commit that referenced this issue Feb 24, 2020
@yihuang @tomtau
Problem (Fix #949): deposit amount fee calculation is not correct
a993b95 
Solution:
- Fix DummySigner for deposit transaction
- Fix mock_enc_dec payload padding
- Test withdraw with viewkeys in the multinode join test (Fix #1101)
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@yihuang yihuang

@tomtau tomtau

@calvinaco calvinaco

@devashishdxt devashishdxt

@leejw51crypto leejw51crypto

Labels
bug Something isn't working
Projects
None yet
Milestone
CRO Sprint 24
Development

No branches or pull requests
6 participants
@yihuang @tomtau @calvinaco @devashishdxt @leejw51crypto @linfeng-crypto