This repository has been archived by the owner on Jul 27, 2022. It is now read-only.
Problem: nowhere to pay fees to (CRO-94) #72
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Solution: added a basic definition + refactor around BlockHeight opaque type: * removed error-prone deref in coin * removed ABCI sanity checks, as they should be done in the ABCI library (added a link to the issue)
Solution: extended InitConfig to contain the dedicated ERC20 addresses that will form the rewards pool at genesis fixed chain-core dependencies changed dev-utils to allow a more flexible config generation
Solution: extracted out app_hash computation into chain-core's `computer_app_hash` and extended InitChain handling
|
@devashishdxt you can check this one. |
Codecov Report
@@ Coverage Diff @@
## master #72 +/- ##
=========================================
Coverage ? 73.68%
=========================================
Files ? 73
Lines ? 4549
Branches ? 0
=========================================
Hits ? 3352
Misses ? 1197
Partials ? 0
|
devashishdxt
previously approved these changes
May 6, 2019
Solution: removed .iter() calls where possible
Solution: added a basic modified mechanism from https://github.com/input-output-hk/rust-cardano
devashishdxt
approved these changes
May 6, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This a work-in-progress PR that will lead to a simple transaction fee system, sketched out in the specs: https://github.com/crypto-com/chain-docs/blob/master/docs/staking.md#transaction-fee
I guess I'll split it into two PRs -- this one will just add a InitChain initialisation of the rewards pool; the other PR will then extend TX, add fee-related network parameters and TX fee validation logic.
(reward distribution will be then another PR some time in the future)
added @CeruleanAtMonaco as a reviewer to double check the initialisation assumption, as she authored the ERC20 contract. The assumption is that the rewards pool will be initialised from:
This change is