Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Problem: sdk 47 is not integrated #1023

Merged
merged 79 commits into from
Feb 26, 2024
Merged

Conversation

yihuang
Copy link
Collaborator

@yihuang yihuang commented Dec 28, 2023

👮🏻👮🏻👮🏻 !!!! REFERENCE THE PROBLEM YOUR ARE SOLVING IN THE PR TITLE AND DESCRIBE YOUR SOLUTION HERE !!!! DO NOT FORGET !!!! 👮🏻👮🏻👮🏻

PR Checklist:

  • Have you read the CONTRIBUTING.md?
  • Does your PR follow the C4 patch requirements?
  • Have you rebased your work on top of the latest master?
  • Have you checked your code compiles? (make)
  • Have you included tests for any non-trivial functionality?
  • Have you checked your code passes the unit tests? (make test)
  • Have you checked your code formatting is correct? (go fmt)
  • Have you checked your basic code style is fine? (golangci-lint run)
  • If you added any dependencies, have you checked they do not contain any known vulnerabilities? (go list -json -m all | nancy sleuth)
  • If your changes affect the client infrastructure, have you run the integration test?
  • If your changes affect public APIs, does your PR follow the C4 evolution of public contracts?
  • If your code changes public APIs, have you incremented the crate version numbers and documented your changes in the CHANGELOG.md?
  • If you are contributing for the first time, please read the agreement in CONTRIBUTING.md now and add a comment to this pull request stating that your PR is in accordance with the Developer's Certificate of Origin.

Thank you for your code, it's appreciated! :)

@yihuang yihuang requested a review from a team as a code owner December 28, 2023 09:33
CHANGELOG.md Outdated Show resolved Hide resolved
Signed-off-by: yihuang <huang@crypto.com>
Copy link
Contributor

@mmsqe mmsqe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we might remove chainmain prefix to avoid register wrong proto type and handle ibc related migrate from v5-to-v6 and v6-to-v7

Copy link

codecov bot commented Dec 29, 2023

Codecov Report

Attention: Patch coverage is 68.81720% with 87 lines in your changes are missing coverage. Please review.

Project coverage is 32.95%. Comparing base (911b8a5) to head (4a273d1).

Files Patch % Lines
app/upgrades.go 66.66% 17 Missing ⚠️
x/nft/types/query.pb.go 64.28% 10 Missing ⚠️
app/test_helpers.go 30.76% 9 Missing ⚠️
app/app.go 88.73% 6 Missing and 2 partials ⚠️
x/nft/client/testutil/test_helpers.go 0.00% 8 Missing ⚠️
x/nft-transfer/types/query.pb.go 62.50% 6 Missing ⚠️
x/nft/types/tx.pb.go 75.00% 5 Missing ⚠️
x/chainmain/client/cli/testnet.go 20.00% 4 Missing ⚠️
x/icaauth/types/params.pb.go 25.00% 3 Missing ⚠️
x/icaauth/types/query.pb.go 62.50% 3 Missing ⚠️
... and 9 more
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1023      +/-   ##
==========================================
+ Coverage   32.91%   32.95%   +0.03%     
==========================================
  Files         130      128       -2     
  Lines       20161    20001     -160     
==========================================
- Hits         6637     6592      -45     
+ Misses      12461    12353     -108     
+ Partials     1063     1056       -7     
Flag Coverage Δ
integration_tests 21.04% <64.20%> (+0.44%) ⬆️
integration_tests_byzantine 9.89% <62.36%> (+0.35%) ⬆️
integration_tests_gov 10.26% <62.73%> (+0.35%) ⬆️
integration_tests_grpc 10.24% <62.73%> (+0.35%) ⬆️
integration_tests_ibc 25.11% <67.52%> (+0.40%) ⬆️
integration_tests_ledger 10.13% <62.36%> (+0.35%) ⬆️
integration_tests_slow 10.13% <62.36%> (+0.35%) ⬆️
integration_tests_solomachine 9.92% <62.36%> (+0.35%) ⬆️
integration_tests_upgrade 10.24% <62.73%> (+0.35%) ⬆️
unit_tests 10.40% <58.27%> (-0.19%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mmsqe mmsqe marked this pull request as ready for review February 23, 2024 04:35
@yihuang yihuang added this pull request to the merge queue Feb 26, 2024
default.nix Outdated Show resolved Hide resolved
@yihuang yihuang removed this pull request from the merge queue due to a manual request Feb 26, 2024
go.mod Outdated Show resolved Hide resolved
app/upgrades.go Outdated Show resolved Hide resolved
nix/rocksdb.nix Outdated Show resolved Hide resolved
nix/rocksdb.nix Outdated Show resolved Hide resolved
mmsqe and others added 3 commits February 26, 2024 16:10
Co-authored-by: yihuang <huang@crypto.com>
Signed-off-by: mmsqe <mavis@crypto.com>
Co-authored-by: yihuang <huang@crypto.com>
Signed-off-by: mmsqe <mavis@crypto.com>
@yihuang yihuang added this pull request to the merge queue Feb 26, 2024
Merged via the queue into crypto-org-chain:master with commit 2dcfd5d Feb 26, 2024
34 of 35 checks passed
@yihuang yihuang deleted the sdk-47 branch February 26, 2024 08:49
yihuang added a commit to yihuang/chain-main that referenced this pull request Apr 18, 2024
Solution:
- revert the package name change introduced in crypto-org-chain#1023.
- don't remember why we have to change it there, but it seems not
  nesserary, revert it to keep it backward compatible.
yihuang added a commit to yihuang/chain-main that referenced this pull request Apr 18, 2024
Solution:
- revert the package name change introduced in crypto-org-chain#1023.
- don't remember why we have to change it there, but it seems not
  nesserary, revert it to keep it backward compatible.

Update CHANGELOG.md

Signed-off-by: yihuang <huang@crypto.com>

match protobuf package name with directory structure

fix test
github-merge-queue bot pushed a commit that referenced this pull request Jul 9, 2024
Solution:
- revert the package name change introduced in #1023.
- don't remember why we have to change it there, but it seems not
  nesserary, revert it to keep it backward compatible.

Update CHANGELOG.md

Signed-off-by: yihuang <huang@crypto.com>

match protobuf package name with directory structure

fix test
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants