Problem: current code is not based on stargate scaffold #55

yihuang · 2020-09-11T17:05:21Z

Solution:

Re-generate with starport's stargate branch

leejw51crypto · 2020-09-12T05:13:03Z

add-genesis-account not working.

i ran this command)
chain-maind add-genesis-account cro1.......................... 200000000cro

tomtau · 2020-09-14T01:52:50Z

add-genesis-account not working.

i ran this command)
chain-maind add-genesis-account cro1.......................... 200000000cro

@leejw51crypto @yihuang it seems this re-generated code 1) doesn't set up bech32 prefixes, 2) does cro->basecro conversion?

leejw51crypto · 2020-09-14T01:54:07Z

chain-maind keys add validator1

generation fine, but

chain-maind keys list
[]

yihuang · 2020-09-14T04:22:56Z

it seems this re-generated code 1) doesn't set up bech32 prefixes,

copied the prefix module from master branch.

does cro->basecro conversion?

did the conversion by hacking the cli arguments.

tomtau · 2020-09-14T04:30:13Z

cmd/chain-maind/cmd/root.go

+	if coin.Denom == "cro" {
+		coin.Denom = "basecro"
+		coin.Amount = coin.Amount.Mul(sdk.NewInt(100000000))
+	}


can this instead call sdk.ConvertCoin(amount, app.BaseCoinUnit) ? just in case we have other units (e.g. "millicro")

If we call sdk.ConvertCoin, we need also register the denominations in cosmos-sdk, the alternative is we just maintain all the conversions here, since the chain itself only care about basecro.

one needs register other types of things in SDK -- it'll be a bit easier to have that in one place and not duplicate what's provided by SDK

cosmos/cosmos-sdk#3510

is it merged?
in my testing, it's not done automatically

it's possible to use "denom_metadata"

cosmos/cosmos-sdk#3510

is it merged?
in my testing, it's not done automatically

It seems they only added the ConvertCoin utility, don't call it in cli. we calls it when pre-process command arguments.

one needs register other types of things in SDK -- it'll be a bit easier to have that in one place and not duplicate what's provided by SDK

done

tomtau · 2020-09-14T04:57:48Z

cmd/chain-maind/cmd/root.go

+func convertDenom(args []string) {
+	if len(args) >= 5 && args[0] == "tx" && args[1] == "bank" && args[2] == "send" {
+		args[5] = convertCoin(args[5])
+	} else if len(args) >= 4 && args[0] == "tx" && args[1] == "staking" && args[2] == "delegate" {


+ unbond + redelegate?

add-genesis-account

also in "init" -- it was modified to put "basecro" as unit in other modules (gov, staking, ...)

@yihuang for init, maybe changing "NewDefaultGenesisState" ?

@yihuang for init, maybe changing "NewDefaultGenesisState" ?

it seems already working? I change the denom in config.yml to "cro", it get translated to "basecro" in genesis.json after starport --serve.

oh, you mean config of other modules, like staking's bond_denom?

before it was doing this https://github.com/crypto-com/chain-main/blob/master/cmd/chain-maind/init.go#L112

Supported the genesis patch by add post-processing to the init command, similar to how starport works.

yihuang · 2020-09-14T07:32:03Z

Current code fails with following backtrace:
(FYI, test with this version of starport: ignite/cli#230)

Validator consensus-address crocnclcons1h5mag6w8lyp0f0gz9dudpyp8fae6n3rl663rxq not found

goroutine 46 [running]:
runtime/debug.Stack(0xc00122b788, 0x51b2080, 0xc0029cea60)
	/usr/local/Cellar/go/1.15/libexec/src/runtime/debug/stack.go:24 +0x9f
github.com/tendermint/tendermint/consensus.(*State).receiveRoutine.func2(0xc0001bd500, 0x5639068)
	/Users/huangyi/go/pkg/mod/github.com/tendermint/tendermint@v0.34.0-rc3/consensus/state.go:684 +0x57
panic(0x51b2080, 0xc0029cea60)
	/usr/local/Cellar/go/1.15/libexec/src/runtime/panic.go:969 +0x175
github.com/cosmos/cosmos-sdk/x/slashing/keeper.Keeper.HandleValidatorSignature(0x57cd560, 0xc0005c0d20, 0x2ec99018, 0xc00007ff80, 0x57f4f40, 0xc0001de240, 0x57eaee0, 0xc00072a060, 0x57e72a0, 0xc0000440e0, ...)
	/Users/huangyi/go/pkg/mod/github.com/cosmos/cosmos-sdk@v0.34.4-0.20200829202026-52ffb269adfc/x/slashing/keeper/infractions.go:20 +0x1dc5
github.com/cosmos/cosmos-sdk/x/slashing.BeginBlocker(0x57e72a0, 0xc0000440e0, 0x57f9800, 0xc0029d6000, 0xb, 0x0, 0xc001043230, 0xa, 0x2, 0x21a6d670, ...)
	/Users/huangyi/go/pkg/mod/github.com/cosmos/cosmos-sdk@v0.34.4-0.20200829202026-52ffb269adfc/x/slashing/abci.go:23 +0x287
github.com/cosmos/cosmos-sdk/x/slashing.AppModule.BeginBlock(...)
	/Users/huangyi/go/pkg/mod/github.com/cosmos/cosmos-sdk@v0.34.4-0.20200829202026-52ffb269adfc/x/slashing/module.go:163
github.com/cosmos/cosmos-sdk/types/module.(*Manager).BeginBlock(0xc00011d0a0, 0x57e72a0, 0xc0000440e0, 0x57f9800, 0xc0029d6000, 0xb, 0x0, 0xc001043230, 0xa, 0x2, ...)
	/Users/huangyi/go/pkg/mod/github.com/cosmos/cosmos-sdk@v0.34.4-0.20200829202026-52ffb269adfc/types/module/module.go:337 +0x1a2
github.com/crypto-com/chain-main/app.(*App).BeginBlocker(...)
	/Users/huangyi/src/chain-main/app/app.go:335
github.com/cosmos/cosmos-sdk/baseapp.(*BaseApp).BeginBlock(0xc0000ec2c0, 0xc0029c79e0, 0x20, 0x20, 0xb, 0x0, 0xc001043230, 0xa, 0x2, 0x21a6d670, ...)
	/Users/huangyi/go/pkg/mod/github.com/cosmos/cosmos-sdk@v0.34.4-0.20200829202026-52ffb269adfc/baseapp/abci.go:147 +0x658
github.com/tendermint/tendermint/abci/client.(*localClient).BeginBlockSync(0xc00061ede0, 0xc0029c79e0, 0x20, 0x20, 0xb, 0x0, 0xc001043230, 0xa, 0x2, 0x21a6d670, ...)
	/Users/huangyi/go/pkg/mod/github.com/tendermint/tendermint@v0.34.0-rc3/abci/client/local_client.go:274 +0xfa
github.com/tendermint/tendermint/proxy.(*appConnConsensus).BeginBlockSync(0xc00022f1a0, 0xc0029c79e0, 0x20, 0x20, 0xb, 0x0, 0xc001043230, 0xa, 0x2, 0x21a6d670, ...)
	/Users/huangyi/go/pkg/mod/github.com/tendermint/tendermint@v0.34.0-rc3/proxy/app_conn.go:81 +0x75
github.com/tendermint/tendermint/state.execBlockOnProxyApp(0x57e7660, 0xc000d323c0, 0x57f2600, 0xc00022f1a0, 0xc00107e8c0, 0x57fb700, 0xc0005a20c8, 0x1, 0xc000045466, 0xa, ...)
	/Users/huangyi/go/pkg/mod/github.com/tendermint/tendermint@v0.34.0-rc3/state/execution.go:294 +0x3a2
github.com/tendermint/tendermint/state.(*BlockExecutor).ApplyBlock(0xc0005ce1c0, 0xb, 0x0, 0xc000045460, 0x6, 0xc000045466, 0xa, 0x1, 0x1, 0xc00107cb20, ...)
	/Users/huangyi/go/pkg/mod/github.com/tendermint/tendermint@v0.34.0-rc3/state/execution.go:137 +0x1a5
github.com/tendermint/tendermint/consensus.(*State).finalizeCommit(0xc0001bd500, 0x2)
	/Users/huangyi/go/pkg/mod/github.com/tendermint/tendermint@v0.34.0-rc3/consensus/state.go:1548 +0x994
github.com/tendermint/tendermint/consensus.(*State).tryFinalizeCommit(0xc0001bd500, 0x2)
	/Users/huangyi/go/pkg/mod/github.com/tendermint/tendermint@v0.34.0-rc3/consensus/state.go:1466 +0x3ba
github.com/tendermint/tendermint/consensus.(*State).enterCommit.func1(0xc0001bd500, 0xc000000000, 0x2)
	/Users/huangyi/go/pkg/mod/github.com/tendermint/tendermint@v0.34.0-rc3/consensus/state.go:1401 +0x8e
github.com/tendermint/tendermint/consensus.(*State).enterCommit(0xc0001bd500, 0x2, 0x0)
	/Users/huangyi/go/pkg/mod/github.com/tendermint/tendermint@v0.34.0-rc3/consensus/state.go:1438 +0x5e5
github.com/tendermint/tendermint/consensus.(*State).addVote(0xc0001bd500, 0xc00129c1e0, 0x0, 0x0, 0x0, 0x0, 0xc0010c3028)
	/Users/huangyi/go/pkg/mod/github.com/tendermint/tendermint@v0.34.0-rc3/consensus/state.go:2001 +0xb28
github.com/tendermint/tendermint/consensus.(*State).tryAddVote(0xc0001bd500, 0xc00129c1e0, 0x0, 0x0, 0x6230e70, 0x563b4d0, 0xc001231bb8)
	/Users/huangyi/go/pkg/mod/github.com/tendermint/tendermint@v0.34.0-rc3/consensus/state.go:1809 +0x59
github.com/tendermint/tendermint/consensus.(*State).handleMsg(0xc0001bd500, 0x57b46a0, 0xc000010ed0, 0x0, 0x0)
	/Users/huangyi/go/pkg/mod/github.com/tendermint/tendermint@v0.34.0-rc3/consensus/state.go:780 +0x865
github.com/tendermint/tendermint/consensus.(*State).receiveRoutine(0xc0001bd500, 0x0)
	/Users/huangyi/go/pkg/mod/github.com/tendermint/tendermint@v0.34.0-rc3/consensus/state.go:731 +0x5ca
created by github.com/tendermint/tendermint/consensus.(*State).OnStart
	/Users/huangyi/go/pkg/mod/github.com/tendermint/tendermint@v0.34.0-rc3/consensus/state.go:370 +0x846

tomtau · 2020-09-14T10:01:17Z

@yihuang the error I traced to is " parameter BondDenom not registered"

yihuang · 2020-09-14T14:10:05Z

@yihuang the error I traced to is " parameter BondDenom not registered"

fixed, seems caused by keeper initialization order.

yihuang · 2020-09-14T17:11:56Z

In my local test, both send tx and delegate tx works, I guess it's good to switch to reviewable now ;D

tomtau · 2020-09-15T01:42:23Z

In my local test, both send tx and delegate tx works, I guess it's good to switch to reviewable now ;D

tried locally now and it seems to work

Solution: - re-generated with starport's stargate branch - ported the fixes (bech32 prefix, bip44 path, denomination conversion) to chain command line

tomtau · 2020-09-15T02:58:45Z

/runsim

devashishdxt

LGTM. Just some lint issues.

yihuang requested review from calvinaco, devashishdxt, leejw51crypto, linfeng-crypto and tomtau as code owners September 11, 2020 17:05

yihuang marked this pull request as draft September 11, 2020 17:05

yihuang force-pushed the stargate branch from e588d2c to ef5df04 Compare September 11, 2020 17:09

yihuang force-pushed the stargate branch 2 times, most recently from f1adb50 to 612cd86 Compare September 14, 2020 04:26

tomtau reviewed Sep 14, 2020

View reviewed changes

yihuang force-pushed the stargate branch from cd66ab1 to 0d22669 Compare September 14, 2020 08:24

yihuang marked this pull request as ready for review September 14, 2020 17:12

tomtau force-pushed the stargate branch from c6d599e to df27422 Compare September 15, 2020 02:56

Problem: current code is not based on stargate scaffold

b53e64d

Solution: - re-generated with starport's stargate branch - ported the fixes (bech32 prefix, bip44 path, denomination conversion) to chain command line

tomtau force-pushed the stargate branch from df27422 to b53e64d Compare September 15, 2020 02:58

devashishdxt approved these changes Sep 15, 2020

View reviewed changes

lint fixes

4cb12c5

tomtau merged commit 19fa3fe into master Sep 15, 2020

tomtau deleted the stargate branch September 15, 2020 04:01

This was referenced Sep 15, 2020

Problem: import-export simulation tests fails with different global account numbers #53

Closed

Problem: default (deprecated) amino json codec #8

Closed

Problem: missing "testnet"/multi-node generation command in Stargate #57

Closed

damoncro pushed a commit to damoncro/chain-main that referenced this pull request Oct 25, 2021

Support ibc tokens to crc20 (crypto-org-chain#55)

a90d406

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Problem: current code is not based on stargate scaffold #55

Problem: current code is not based on stargate scaffold #55

yihuang commented Sep 11, 2020

leejw51crypto commented Sep 12, 2020

tomtau commented Sep 14, 2020

leejw51crypto commented Sep 14, 2020 •

edited

Loading

yihuang commented Sep 14, 2020

tomtau Sep 14, 2020

yihuang Sep 14, 2020 •

edited

Loading

tomtau Sep 14, 2020

leejw51crypto Sep 14, 2020

tomtau Sep 14, 2020

yihuang Sep 14, 2020 •

edited

Loading

yihuang Sep 14, 2020

tomtau Sep 14, 2020 •

edited

Loading

tomtau Sep 14, 2020

tomtau Sep 14, 2020

yihuang Sep 14, 2020

tomtau Sep 14, 2020

yihuang Sep 14, 2020 •

edited

Loading

yihuang Sep 14, 2020 •

edited

Loading

tomtau Sep 14, 2020

tomtau Sep 14, 2020

yihuang Sep 14, 2020 •

edited

Loading

yihuang commented Sep 14, 2020 •

edited

Loading

tomtau commented Sep 14, 2020

yihuang commented Sep 14, 2020

yihuang commented Sep 14, 2020

tomtau commented Sep 15, 2020

tomtau commented Sep 15, 2020

devashishdxt left a comment

Problem: current code is not based on stargate scaffold #55

Problem: current code is not based on stargate scaffold #55

Conversation

yihuang commented Sep 11, 2020

leejw51crypto commented Sep 12, 2020

tomtau commented Sep 14, 2020

leejw51crypto commented Sep 14, 2020 • edited Loading

yihuang commented Sep 14, 2020

Choose a reason for hiding this comment

yihuang Sep 14, 2020 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

yihuang Sep 14, 2020 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

tomtau Sep 14, 2020 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

yihuang Sep 14, 2020 • edited Loading

Choose a reason for hiding this comment

yihuang Sep 14, 2020 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

yihuang Sep 14, 2020 • edited Loading

Choose a reason for hiding this comment

yihuang commented Sep 14, 2020 • edited Loading

tomtau commented Sep 14, 2020

yihuang commented Sep 14, 2020

yihuang commented Sep 14, 2020

tomtau commented Sep 15, 2020

tomtau commented Sep 15, 2020

devashishdxt left a comment

Choose a reason for hiding this comment

leejw51crypto commented Sep 14, 2020 •

edited

Loading

yihuang Sep 14, 2020 •

edited

Loading

yihuang Sep 14, 2020 •

edited

Loading

tomtau Sep 14, 2020 •

edited

Loading

yihuang Sep 14, 2020 •

edited

Loading

yihuang Sep 14, 2020 •

edited

Loading

yihuang Sep 14, 2020 •

edited

Loading

yihuang commented Sep 14, 2020 •

edited

Loading