Problem: didn't disable the url query parameter in swagger ui #704
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Solution: - update to recent swagger ui version - add option `queryConfigEnabled: false`
Codecov Report
@@ Coverage Diff @@
## master #704 +/- ##
==========================================
+ Coverage 19.35% 22.63% +3.27%
==========================================
Files 71 70 -1
Lines 7953 8073 +120
==========================================
+ Hits 1539 1827 +288
+ Misses 5903 5696 -207
- Partials 511 550 +39
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
yihuang
commented
Feb 15, 2022
| @@ -629,7 +629,7 @@ func (app *ChainApp) RegisterTendermintService(clientCtx client.Context) { | |||
|
|
|||
| // RegisterSwaggerAPI registers swagger route with API Server | |||
| func RegisterSwaggerAPI(ctx client.Context, rtr *mux.Router) { | |||
| statikFS, err := fs.New() | |||
| statikFS, err := fs.NewWithNamespace("chainmain") | |||
There was a problem hiding this comment.
used a different namespace to prevent potential conflict with the one used by cosmos-sdk's simd.
tomtau
approved these changes
Feb 16, 2022
This was referenced Mar 1, 2022
tomtau
pushed a commit
that referenced
this pull request
Mar 1, 2022
Solution: - update to recent swagger ui version - add option `queryConfigEnabled: false`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Solution:
queryConfigEnabled: false👮🏻👮🏻👮🏻 !!!! REFERENCE THE PROBLEM YOUR ARE SOLVING IN THE PR TITLE AND DESCRIBE YOUR SOLUTION HERE !!!! DO NOT FORGET !!!! 👮🏻👮🏻👮🏻
PR Checklist:
make)make test)go fmt)golangci-lint run)go list -json -m all | nancy sleuth)Thank you for your code, it's appreciated! :)