Problem: Missing ICA auth module for enabling interchain accounts #730

devashishdxt · 2022-03-16T14:57:19Z

Solution: Added a basic ICA auth module

As described in #719, interchain accounts feature will be divided in three separate PRs. This is the first one which adds a basic ICA auth module.

Ref: https://github.com/cosmos/ibc-go/blob/v3.0.0/docs/apps/interchain-accounts/auth-modules.md

Solution: Added a basic ICA auth module

codecov · 2022-03-16T15:16:21Z

Codecov Report

Merging #730 (f59b5c0) into master (d2558d4) will increase coverage by 1.14%.
The diff coverage is 1.78%.

@@            Coverage Diff             @@
##           master     #730      +/-   ##
==========================================
+ Coverage   19.45%   20.60%   +1.14%     
==========================================
  Files          70       76       +6     
  Lines        7931     9989    +2058     
==========================================
+ Hits         1543     2058     +515     
- Misses       5876     7465    +1589     
+ Partials      512      466      -46

Flag	Coverage Δ
integration_tests	`19.95% <ø> (+0.49%)`	⬆️
unit_tests	`7.51% <1.78%> (?)`

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
x/icaauth/types/codec.go	`0.00% <0.00%> (ø)`
x/icaauth/types/query.pb.gw.go	`0.00% <0.00%> (ø)`
x/icaauth/types/tx.pb.go	`0.84% <0.84%> (ø)`
x/icaauth/types/query.pb.go	`0.92% <0.92%> (ø)`
x/icaauth/types/message_submit_tx.go	`10.25% <10.25%> (ø)`
x/icaauth/types/message_register_account.go	`26.66% <26.66%> (ø)`
x/icaauth/types/types.go	`100.00% <100.00%> (ø)`
app/app.go	`4.60% <0.00%> (-86.02%)`	⬇️
x/nft/types/codec.go	`90.32% <0.00%> (-9.68%)`	⬇️
x/nft/client/cli/flags.go	`100.00% <0.00%> (ø)`
... and 15 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d2558d4...f59b5c0. Read the comment docs.

tomtau

does it need to be a separate module or could the functionality be added to an existing module? I'm thinking that x/chainmain is pretty much empty, but ok to keep it separate too

devashishdxt · 2022-03-17T01:16:15Z

does it need to be a separate module or could the functionality be added to an existing module? I'm thinking that x/chainmain is pretty much empty, but ok to keep it separate too

It does not need to be in a separate module but it's better to keep it separate for clarity and logical separation.

tomtau · 2022-03-17T01:54:03Z

ok, I'll need to read https://github.com/cosmos/ibc-go/blob/v3.0.0/docs/apps/interchain-accounts/auth-modules.md first

tomtau

I'm a bit puzzled about the OnAcknowledgementPacket section -- is that done in ibc-go?

x/icaauth/module_ibc.go

devashishdxt · 2022-03-17T02:13:55Z

I'm a bit puzzled about the OnAcknowledgementPacket section -- is that done in ibc-go?

Yes. For packet acknowledgement, both ica-auth and ica-controller (which is in ibc-go) will be called. Ref: https://github.com/cosmos/ibc-go/blob/f83aa8201eaa7b9daa2b34e4e44a219066e6e958/modules/apps/27-interchain-accounts/controller/ibc_module.go#L136

sonatype-lift · 2022-03-17T02:49:05Z

x/icaauth/types/query.pb.gw.go

+var _ status.Status
+var _ = runtime.String
+var _ = utilities.NewDoubleArray
+var _ = descriptor.ForMessage


SA1019: descriptor.ForMessage is deprecated: Not all concrete message types satisfy the Message interface. Use MessageDescriptorProto instead. If possible, the calling code should be rewritten to use protobuf reflection instead. See package "google.golang.org/protobuf/reflect/protoreflect" for details.
(at-me in a reply with help or ignore)

sonatype-lift · 2022-03-17T02:49:06Z

x/icaauth/types/query.pb.gw.go

+	"io"
+	"net/http"
+
+	"github.com/golang/protobuf/descriptor"


SA1019: package github.com/golang/protobuf/descriptor is deprecated: See the "google.golang.org/protobuf/reflect/protoreflect" package for how to obtain an EnumDescriptor or MessageDescriptor in order to programatically interact with the protobuf type system.
(at-me in a reply with help or ignore)

sonatype-lift · 2022-03-17T02:49:07Z

x/icaauth/types/query.pb.gw.go

+	"net/http"
+
+	"github.com/golang/protobuf/descriptor"
+	"github.com/golang/protobuf/proto"


SA1019: package github.com/golang/protobuf/proto is deprecated: Use the "google.golang.org/protobuf/proto" package instead.
(at-me in a reply with help or ignore)

tomtau

it's probably ok -- the app wiring, upgrade handler etc. will be a separate PR if I understand the plan

x/icaauth/types/message_submit_tx.go

x/icaauth/module.go

tomtau · 2022-03-17T03:35:41Z

@devashishdxt would a different protobuf generator version use non-deprecated packages?

devashishdxt · 2022-03-17T03:38:02Z

@devashishdxt would a different protobuf generator version use non-deprecated packages?

Maybe if we upgrade to newer version then it won't use deprecated packages. But, I don't think we can stop using these deprecated packages in our code until cosmos-sdk removes/upgrades it in their interfaces.

devashishdxt · 2022-03-17T03:39:16Z

@devashishdxt would a different protobuf generator version use non-deprecated packages?

I can see that cosmos-sdk is using these packages even in v0.46.0-alpha3.

Problem: Missing ICA auth module for enable interchain accounts

765ac6b

Solution: Added a basic ICA auth module

devashishdxt requested review from tomtau, calvinaco and yihuang as code owners March 16, 2022 14:57

devashishdxt mentioned this pull request Mar 16, 2022

Problem: Interchain accounts are not enabled in chain-main #719

Closed

3 tasks

Fixed lint errors

911f0f2

devashishdxt changed the title ~~Problem: Missing ICA auth module for enable interchain accounts~~ Problem: Missing ICA auth module for enabling interchain accounts Mar 16, 2022

tomtau reviewed Mar 17, 2022

View reviewed changes

x/icaauth/module_ibc.go Outdated Show resolved Hide resolved

Return error instead of panic

38d06ec

sonatype-lift bot reviewed Mar 17, 2022

View reviewed changes

tomtau approved these changes Mar 17, 2022

View reviewed changes

x/icaauth/types/message_submit_tx.go Show resolved Hide resolved

x/icaauth/module.go Outdated Show resolved Hide resolved

Change consensus version to 1

f59b5c0

devashishdxt merged commit 7dc44f8 into crypto-org-chain:master Mar 17, 2022

devashishdxt deleted the ica-auth-module branch March 17, 2022 03:25

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Problem: Missing ICA auth module for enabling interchain accounts #730

Problem: Missing ICA auth module for enabling interchain accounts #730

devashishdxt commented Mar 16, 2022

codecov bot commented Mar 16, 2022 •

edited

tomtau left a comment

devashishdxt commented Mar 17, 2022

tomtau commented Mar 17, 2022

tomtau left a comment

devashishdxt commented Mar 17, 2022

sonatype-lift bot Mar 17, 2022

sonatype-lift bot Mar 17, 2022

sonatype-lift bot Mar 17, 2022

tomtau left a comment

tomtau commented Mar 17, 2022 •

edited

devashishdxt commented Mar 17, 2022

devashishdxt commented Mar 17, 2022

Problem: Missing ICA auth module for enabling interchain accounts #730

Problem: Missing ICA auth module for enabling interchain accounts #730

Conversation

devashishdxt commented Mar 16, 2022

codecov bot commented Mar 16, 2022 • edited

Codecov Report

tomtau left a comment

Choose a reason for hiding this comment

devashishdxt commented Mar 17, 2022

tomtau commented Mar 17, 2022

tomtau left a comment

Choose a reason for hiding this comment

devashishdxt commented Mar 17, 2022

sonatype-lift bot Mar 17, 2022

Choose a reason for hiding this comment

sonatype-lift bot Mar 17, 2022

Choose a reason for hiding this comment

sonatype-lift bot Mar 17, 2022

Choose a reason for hiding this comment

tomtau left a comment

Choose a reason for hiding this comment

tomtau commented Mar 17, 2022 • edited

devashishdxt commented Mar 17, 2022

devashishdxt commented Mar 17, 2022

codecov bot commented Mar 16, 2022 •

edited

tomtau commented Mar 17, 2022 •

edited