Problem: Missing integration tests for interchain accounts #733
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Solution: Added integration tests
devashishdxt
requested review from
tomtau,
calvinaco and
yihuang
as code owners
3 tasks
Codecov Report
@@ Coverage Diff @@
## master #733 +/- ##
==========================================
- Coverage 21.03% 18.41% -2.62%
==========================================
Files 89 89
Lines 10226 10050 -176
==========================================
- Hits 2151 1851 -300
- Misses 7599 7762 +163
+ Partials 476 437 -39
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
![sonatype-lift[bot]](https://avatars.githubusercontent.com/in/9843?s=60&v=4){kind=small}
| @@ -0,0 +1,153 @@ | |||
| import json | |||
| import subprocess | |||
There was a problem hiding this comment.
blacklist: Consider possible security implications associated with the subprocess module.
(at-me in a reply with help or ignore)
integration_tests/test_ica.py
Outdated
| rsp = json.loads(subprocess.check_output(relayer + ["query", "connections", "ica-controller-1"])) | ||
| controller_connection = rsp["result"][0] | ||
|
|
||
| rsp = json.loads(subprocess.check_output(relayer + ["query", "connections", "ica-host-1"])) |
There was a problem hiding this comment.
subprocess_without_shell_equals_true: subprocess call - check for execution of untrusted input.
(at-me in a reply with help or ignore)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Solution: Added integration tests