Problem: No human-friendly date entry for vesting time #96
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
devashishdxt
requested review from
calvinaco,
leejw51crypto,
linfeng-crypto,
tomtau and
yihuang
as code owners
tomtau
reviewed
Sep 21, 2020
go.sum
Outdated
| @@ -101,6 +101,7 @@ github.com/coreos/pkg v0.0.0-20160727233714-3ac0863d7acf/go.mod h1:E3G3o1h8I7cfc | |||
| github.com/coreos/pkg v0.0.0-20180928190104-399ea9e2e55f/go.mod h1:E3G3o1h8I7cfcXa63jLwjI0eiQQMgzzUDFVpN/nH/eA= | |||
| github.com/cosmos/cosmos-sdk v0.34.4-0.20200914065108-201787bba330 h1:sbiGI8l2C71tPUI/GbWLnrywwwcSDHhlwPf+lv21XvQ= | |||
| github.com/cosmos/cosmos-sdk v0.34.4-0.20200914065108-201787bba330/go.mod h1:3vJCSbqKwPuASUuhXymmzDlefbjtG5t+O+bT12zmxTo= | |||
| github.com/cosmos/cosmos-sdk v0.39.1 h1:vhjf9PZh9ph8btAj9aBpHoVITgVVjNBpM3x5Gl/Vwac= | |||
There was a problem hiding this comment.
Don't know why this is here. I'll remove this.
There was a problem hiding this comment.
probably somewhere in the code imports a module which is only exists in 0.39.1.
never mind, no import change in this pr.
devashishdxt
force-pushed
the
vesting-time
branch
2 times, most recently
from
9a54065
to
3b3f1f1
Compare
tomtau
reviewed
Sep 21, 2020
doc/vesting.md
Outdated
| @@ -2,11 +2,11 @@ | |||
| Vesting can be configured at genesis time. | |||
| There are different "vesting account types". | |||
| The intended one is "delayed vesting" where the full amount is locked until a specified date. | |||
| It can be configured using command-line tooling (the time is currently specified using the unix timestamp), | |||
| It can be configured using command-line tooling (the time is currently specified using RFC-3339 format `2006-01-02T15:04:05Z07:00`), | |||
There was a problem hiding this comment.
that's in UTC? probably good to mention that if timezone offsets are supported to (they are ? timezone separator ("Z") is optional?
There was a problem hiding this comment.
Added examples for UTC and other timezone with offset.
devashishdxt
force-pushed
the
vesting-time
branch
from
3b3f1f1
to
7268fea
Compare
yihuang
approved these changes
Sep 21, 2020
Solution: Parse date string using RFC-3339. Fixes #59.
devashishdxt
force-pushed
the
vesting-time
branch
from
7268fea
to
8cefc6d
Compare
damoncro
pushed a commit
to damoncro/chain-main
that referenced
this pull request
Oct 25, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Solution: Parse date string using RFC-3339. Fixes #59.