Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Problem: query legacy block failed after upgrade #446

Merged
merged 5 commits into from
May 3, 2022

Conversation

yihuang
Copy link
Collaborator

@yihuang yihuang commented Apr 29, 2022

Solution:

  • fix in ethermint and update the dependency

馃懏馃徎馃懏馃徎馃懏馃徎 !!!! REFERENCE THE PROBLEM YOUR ARE SOLVING IN THE PR TITLE AND DESCRIBE YOUR SOLUTION HERE !!!! DO NOT FORGET !!!! 馃懏馃徎馃懏馃徎馃懏馃徎

PR Checklist:

  • Have you read the CONTRIBUTING.md?
  • Does your PR follow the C4 patch requirements?
  • Have you rebased your work on top of the latest master?
  • Have you checked your code compiles? (make)
  • Have you included tests for any non-trivial functionality?
  • Have you checked your code passes the unit tests? (make test)
  • Have you checked your code formatting is correct? (go fmt)
  • Have you checked your basic code style is fine? (golangci-lint run)
  • If you added any dependencies, have you checked they do not contain any known vulnerabilities? (go list -json -m all | nancy sleuth)
  • If your changes affect the client infrastructure, have you run the integration test?
  • If your changes affect public APIs, does your PR follow the C4 evolution of public contracts?
  • If your code changes public APIs, have you incremented the crate version numbers and documented your changes in the CHANGELOG.md?
  • If you are contributing for the first time, please read the agreement in CONTRIBUTING.md now and add a comment to this pull request stating that your PR is in accordance with the Developer's Certificate of Origin.

Thank you for your code, it's appreciated! :)

Solution:
- fix in ethermint and update the dependency
@yihuang yihuang requested a review from a team as a code owner April 29, 2022 03:25
@yihuang yihuang requested review from devashishdxt and thomas-nguy and removed request for a team April 29, 2022 03:25
@yihuang yihuang marked this pull request as draft April 29, 2022 03:25
go.mod Outdated Show resolved Hide resolved
@codecov
Copy link

codecov bot commented Apr 29, 2022

Codecov Report

Merging #446 (9319573) into main (3ea70c5) will increase coverage by 17.88%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##             main     #446       +/-   ##
===========================================
+ Coverage   21.51%   39.40%   +17.88%     
===========================================
  Files          27       31        +4     
  Lines        1729     1571      -158     
===========================================
+ Hits          372      619      +247     
+ Misses       1324      906      -418     
- Partials       33       46       +13     
Impacted Files Coverage 螖
x/cronos/genesis.go 61.53% <酶> (-38.47%) 猬囷笍
x/cronos/handler.go 100.00% <酶> (酶)
x/cronos/keeper/evm.go 58.00% <酶> (+6.27%) 猬嗭笍
x/cronos/keeper/evm_hooks.go 80.00% <酶> (酶)
x/cronos/keeper/evm_log_handlers.go 83.50% <酶> (酶)
x/cronos/keeper/gravity_hooks.go 0.00% <酶> (酶)
x/cronos/keeper/grpc_query.go 0.00% <酶> (酶)
x/cronos/keeper/ibc.go 83.20% <酶> (+5.01%) 猬嗭笍
x/cronos/keeper/ibc_hooks.go 50.00% <酶> (-8.83%) 猬囷笍
x/cronos/keeper/keeper.go 65.26% <酶> (-29.08%) 猬囷笍
... and 29 more

@yihuang yihuang marked this pull request as ready for review April 30, 2022 16:35
@@ -160,7 +160,7 @@ replace (

github.com/gogo/protobuf => github.com/regen-network/protobuf v1.3.3-alpha.regen.1

github.com/tharsis/ethermint => github.com/crypto-org-chain/ethermint v0.10.0-alpha1-cronos-8.0.20220426081631-a178ce6dba6e
github.com/tharsis/ethermint => github.com/crypto-org-chain/ethermint v0.10.0-alpha1-cronos-8.0.20220430162531-36b9c095b351
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@yihuang yihuang mentioned this pull request May 1, 2022
13 tasks
@yihuang yihuang requested review from tomtau and JayT106 May 3, 2022 01:11
@yihuang yihuang assigned adu-crypto and unassigned adu-crypto May 3, 2022
@yihuang yihuang requested a review from adu-crypto May 3, 2022 01:12
Copy link
Contributor

@tomtau tomtau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why is there a need for the ethermint fork? can the upstream be used if the PRs are merged?

@yihuang
Copy link
Collaborator Author

yihuang commented May 3, 2022

why is there a need for the ethermint fork? can the upstream be used if the PRs are merged?

there's still breaking changes are not included for 0.7.0 upgrade, including the ibc-go 0.3, so we'll need to maintain this fork for the 0.7.0 release.

@yihuang yihuang merged commit 5291768 into crypto-org-chain:main May 3, 2022
@yihuang yihuang deleted the fix-get-block-api branch May 3, 2022 02:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants