Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Problem: file changes detection in workflow is problematic #703

Merged
merged 2 commits into from
Sep 19, 2022
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions .github/workflows/build.yml
Original file line number Diff line number Diff line change
Expand Up @@ -66,7 +66,9 @@ jobs:
gomod2nix:
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v2.3.4
- uses: actions/checkout@v3
with:
fetch-depth: 0
- id: changed-files
uses: tj-actions/changed-files@v29.0.2
with:
Expand Down Expand Up @@ -95,7 +97,9 @@ jobs:
contracts:
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v2.3.4
- uses: actions/checkout@v3
with:
fetch-depth: 0
- id: changed-files
uses: tj-actions/changed-files@v29.0.2
with:
Expand Down
6 changes: 4 additions & 2 deletions .github/workflows/linkchecker.yml
Original file line number Diff line number Diff line change
Expand Up @@ -11,12 +11,14 @@ jobs:
markdown-link-check:
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v2.3.4
- uses: actions/checkout@v3
with:
fetch-depth: 0
- id: changed-files
uses: tj-actions/changed-files@v29.0.2
with:
files: |
docs/**.md
docs/**/*.md
- uses: gaurav-nelson/github-action-markdown-link-check@1.0.13
if: steps.changed-files.outputs.any_changed == 'true'
with:
Expand Down
13 changes: 9 additions & 4 deletions .github/workflows/lint.yml
Original file line number Diff line number Diff line change
Expand Up @@ -42,14 +42,16 @@ jobs:
name: Lint python
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v2
- uses: actions/checkout@v3
with:
fetch-depth: 0
- id: changed-files
uses: tj-actions/changed-files@v29.0.2
with:
files: |
**/poetry.lock
**/pyproject.toml
**.py
**/*.py
- uses: cachix/install-nix-action@v15
if: steps.changed-files.outputs.any_changed == 'true'
- uses: cachix/cachix-action@v10
Expand All @@ -63,12 +65,15 @@ jobs:
name: Lint nix
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v2
- uses: actions/checkout@v3
with:
fetch-depth: 0
- id: changed-files
uses: tj-actions/changed-files@v29.0.2
with:
files: |
**.nix
*.nix
**/*.nix
- uses: cachix/install-nix-action@v15
if: steps.changed-files.outputs.any_changed == 'true'
- run: nix-shell -I nixpkgs=./nix -p nixpkgs-fmt --run "make lint-nix"
Expand Down
12 changes: 9 additions & 3 deletions .github/workflows/test.yml
Original file line number Diff line number Diff line change
Expand Up @@ -16,13 +16,16 @@ jobs:
integration_tests:
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v2
- uses: actions/checkout@v3
with:
fetch-depth: 0
- id: changed-files
uses: tj-actions/changed-files@v29.0.2
with:
files: |
docs
**.md
*.md
**/*.md
- uses: cachix/install-nix-action@v15
if: steps.changed-files.outputs.only_changed == 'false'
- uses: cachix/cachix-action@v10
Expand Down Expand Up @@ -54,13 +57,16 @@ jobs:
os: [macos-latest]
runs-on: ${{ matrix.os }}
steps:
- uses: actions/checkout@v2
- uses: actions/checkout@v3
with:
fetch-depth: 0
- id: changed-files
uses: tj-actions/changed-files@v29.0.2
with:
files: |
docs
*.md
**/*.md
- uses: cachix/install-nix-action@v15
if: steps.changed-files.outputs.only_changed == 'false'
- uses: cachix/cachix-action@v10
Expand Down
8 changes: 4 additions & 4 deletions integration_tests/test_gravity.py
Original file line number Diff line number Diff line change
Expand Up @@ -275,7 +275,7 @@ def local_check_auto_deployment():

# send it back to erc20
tx = crc21_contract.functions.send_to_evm_chain(
ADDRS["validator"], amount, 1, 0, b''
ADDRS["validator"], amount, 1, 0, b""
).buildTransaction({"from": ADDRS["community"]})
txreceipt = send_transaction(cronos_w3, tx, KEYS["community"])
# CRC20 emit 3 logs for send_to_evm_chain:
Expand Down Expand Up @@ -482,7 +482,7 @@ def local_check_auto_deployment():

# send it back to erc20
tx = crc21_contract.functions.send_to_evm_chain(
ADDRS["validator"], amount, 1, 0, b''
ADDRS["validator"], amount, 1, 0, b""
).buildTransaction({"from": community})
txreceipt = send_transaction(cronos_w3, tx, KEYS["community"])
# CRC20 emit 3 logs for send_to_evm_chain:
Expand Down Expand Up @@ -565,7 +565,7 @@ def test_gravity_source_tokens(gravity):

print("send to ethereum")
tx = contract.functions.send_to_evm_chain(
ethereum_receiver, amount, 1, 0, b''
ethereum_receiver, amount, 1, 0, b""
).buildTransaction({"from": ADDRS["validator"]})
txreceipt = send_transaction(w3, tx)
assert txreceipt.status == 1, "should success"
Expand Down Expand Up @@ -651,7 +651,7 @@ def local_check_auto_deployment():

# send it back to blacklisted address
tx = crc21_contract.functions.send_to_evm_chain(
ADDRS["signer1"], amount, 1, 0, b''
ADDRS["signer1"], amount, 1, 0, b""
).buildTransaction({"from": ADDRS["community"]})
txreceipt = send_transaction(cronos_w3, tx, KEYS["community"])
assert txreceipt.status == 1, "should success"
Expand Down
6 changes: 3 additions & 3 deletions integration_tests/test_ibc.py
Original file line number Diff line number Diff line change
Expand Up @@ -270,9 +270,9 @@ def test_cronos_transfer_source_tokens(ibc):
assert chainmain_receiver_balance == 0

# send to ibc
tx = contract.functions.send_to_ibc_v2(chainmain_receiver, amount, 0, b'').buildTransaction(
{"from": ADDRS["validator"]}
)
tx = contract.functions.send_to_ibc_v2(
chainmain_receiver, amount, 0, b""
).buildTransaction({"from": ADDRS["validator"]})
txreceipt = send_transaction(w3, tx)
assert txreceipt.status == 1, "should success"

Expand Down