-
Notifications
You must be signed in to change notification settings - Fork 225
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Problem: go1.20 is not used #845
Conversation
Closes: crypto-org-chain#844 Solution: - use go 1.20 - setup go coverage support for integration test
Signed-off-by: yihuang <huang@crypto.com>
I can reproduce this issue, maybe something wrong with this new golang feature. |
I thought it error on report on 1st time, since profile.txt is normal when I tried
|
I guess we should merge the nixpkgs and golang version upgrade first, then debugging the coverage thing, otherwise, the integration test workflow takes 2hours each time. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, could you describe the purpose we change the nixpkgs from release version to the master? Thanks.
just for the go 1.20 which is only in the master branch, the coverage feature is only introduced in latest golang 1.20 |
golang/go#58411 |
Merge queue setting changed
Merge queue setting changed
Closes: #844
Solution:
👮🏻👮🏻👮🏻 !!!! REFERENCE THE PROBLEM YOUR ARE SOLVING IN THE PR TITLE AND DESCRIBE YOUR SOLUTION HERE !!!! DO NOT FORGET !!!! 👮🏻👮🏻👮🏻
PR Checklist:
make
)make test
)go fmt
)golangci-lint run
)go list -json -m all | nancy sleuth
)Thank you for your code, it's appreciated! :)