Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Problem: no parsed log from old event #482

Merged
merged 2 commits into from
May 2, 2024

Conversation

mmsqe
Copy link
Collaborator

@mmsqe mmsqe commented Apr 30, 2024

  • this change should have been included in 7a841e8
  • skip txResponses length check

Closes: #XXX

Description


For contributor use:

  • Targeted PR against correct branch (see CONTRIBUTING.md)
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards.
  • Wrote unit and integration tests
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/)
  • Added relevant godoc comments.
  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer

For admin use:

  • Added appropriate labels to PR (ex. WIP, R4R, docs, etc)
  • Reviewers assigned
  • Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)

* this change should have been included in 7a841e8
* skip txResponses length check
Copy link

codecov bot commented Apr 30, 2024

Codecov Report

Attention: Patch coverage is 0% with 3 lines in your changes are missing coverage. Please review.

Project coverage is 61.53%. Comparing base (62852ba) to head (e72f55b).

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #482      +/-   ##
===========================================
+ Coverage    61.52%   61.53%   +0.01%     
===========================================
  Files          127      127              
  Lines         9479     9477       -2     
===========================================
  Hits          5832     5832              
+ Misses        3109     3107       -2     
  Partials       538      538              
Files Coverage Δ
x/evm/types/utils.go 33.06% <0.00%> (+0.52%) ⬆️

@mmsqe mmsqe requested a review from yihuang May 2, 2024 01:40
@yihuang yihuang enabled auto-merge (squash) May 2, 2024 05:08
@yihuang yihuang merged commit 179e436 into crypto-org-chain:develop May 2, 2024
38 of 39 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants