Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Problem: pending tx comes after get mined #488

Merged
merged 8 commits into from
Jun 6, 2024

Conversation

mmsqe
Copy link
Collaborator

@mmsqe mmsqe commented May 24, 2024

Closes: #XXX

Description


For contributor use:

  • Targeted PR against correct branch (see CONTRIBUTING.md)
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards.
  • Wrote unit and integration tests
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/)
  • Added relevant godoc comments.
  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer

For admin use:

  • Added appropriate labels to PR (ex. WIP, R4R, docs, etc)
  • Reviewers assigned
  • Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)

rpc/stream/rpc.go Fixed Show fixed Hide fixed
Copy link

codecov bot commented May 24, 2024

Codecov Report

Attention: Patch coverage is 0% with 26 lines in your changes missing coverage. Please review.

Project coverage is 61.56%. Comparing base (179e436) to head (506f7f0).

Current head 506f7f0 differs from pull request most recent head e614cbb

Please upload reports for the commit e614cbb to get more accurate results.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #488      +/-   ##
===========================================
+ Coverage    61.53%   61.56%   +0.02%     
===========================================
  Files          127      127              
  Lines         9477     9473       -4     
===========================================
  Hits          5832     5832              
+ Misses        3107     3103       -4     
  Partials       538      538              
Files Coverage Δ
app/app.go 75.84% <0.00%> (-1.11%) ⬇️
rpc/stream/rpc.go 0.00% <0.00%> (ø)

rpc/stream/rpc.go Fixed Show fixed Hide fixed
@mmsqe mmsqe marked this pull request as ready for review May 31, 2024 01:31
@mmsqe mmsqe requested a review from yihuang May 31, 2024 01:31
app/app.go Outdated Show resolved Hide resolved
@@ -92,7 +87,7 @@
return nil, err
}

go s.start(&s.wg, chBlocks, chTx, chLogs)
go s.start(&s.wg, chBlocks, chLogs)

Check notice

Code scanning / CodeQL

Spawning a Go routine Note

Spawning a Go routine may be a possible source of non-determinism
app/app.go Show resolved Hide resolved
@yihuang yihuang self-requested a review June 6, 2024 12:47
@mmsqe mmsqe enabled auto-merge (squash) June 6, 2024 13:03
@mmsqe mmsqe merged commit 6f4031d into crypto-org-chain:develop Jun 6, 2024
32 of 33 checks passed
@yihuang yihuang deleted the pending_events branch June 7, 2024 01:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants