Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Problem: pending tx comes after get mined (backport: #488) #489

Conversation

mmsqe
Copy link
Collaborator

@mmsqe mmsqe commented Jun 7, 2024

Closes: #XXX

Description


For contributor use:

  • Targeted PR against correct branch (see CONTRIBUTING.md)
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards.
  • Wrote unit and integration tests
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/)
  • Added relevant godoc comments.
  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer

For admin use:

  • Added appropriate labels to PR (ex. WIP, R4R, docs, etc)
  • Reviewers assigned
  • Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)

@mmsqe mmsqe requested a review from yihuang June 7, 2024 01:37
Copy link

codecov bot commented Jun 7, 2024

Codecov Report

Attention: Patch coverage is 0% with 27 lines in your changes missing coverage. Please review.

Project coverage is 64.07%. Comparing base (814fcac) to head (d6fed7e).

Additional details and impacted files

Impacted file tree graph

@@                    Coverage Diff                     @@
##           release/v0.22.x-cronos     #489      +/-   ##
==========================================================
+ Coverage                   64.05%   64.07%   +0.01%     
==========================================================
  Files                         129      129              
  Lines                        9742     9739       -3     
==========================================================
  Hits                         6240     6240              
+ Misses                       2995     2992       -3     
  Partials                      507      507              
Files Coverage Δ
app/app.go 80.81% <0.00%> (-1.42%) ⬇️
rpc/stream/rpc.go 0.00% <0.00%> (ø)

@mmsqe mmsqe enabled auto-merge (squash) June 7, 2024 01:53
@mmsqe mmsqe merged commit b82677b into crypto-org-chain:release/v0.22.x-cronos Jun 7, 2024
28 of 31 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants