Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Problem: decode tx is unnecessary in tx listener (backport: #491) #492

Conversation

mmsqe
Copy link
Collaborator

@mmsqe mmsqe commented Jun 10, 2024

  • Problem: decode tx is unnecessary in tx listener

  • cleanup

Closes: #XXX

Description


For contributor use:

  • Targeted PR against correct branch (see CONTRIBUTING.md)
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards.
  • Wrote unit and integration tests
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/)
  • Added relevant godoc comments.
  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer

For admin use:

  • Added appropriate labels to PR (ex. WIP, R4R, docs, etc)
  • Reviewers assigned
  • Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)

* Problem: decode tx is unnecessary in tx listener

* cleanup
@mmsqe mmsqe requested a review from yihuang June 10, 2024 01:14
Copy link

codecov bot commented Jun 10, 2024

Codecov Report

Attention: Patch coverage is 44.44444% with 10 lines in your changes missing coverage. Please review.

Project coverage is 64.14%. Comparing base (b82677b) to head (960508b).

Additional details and impacted files

Impacted file tree graph

@@                    Coverage Diff                     @@
##           release/v0.22.x-cronos     #492      +/-   ##
==========================================================
+ Coverage                   64.07%   64.14%   +0.07%     
==========================================================
  Files                         129      130       +1     
  Lines                        9739     9740       +1     
==========================================================
+ Hits                         6240     6248       +8     
+ Misses                       2992     2984       -8     
- Partials                      507      508       +1     
Files Coverage Δ
app/ante/handler_options.go 83.33% <100.00%> (+0.28%) ⬆️
rpc/stream/rpc.go 0.00% <0.00%> (ø)
app/ante/tx_listener.go 60.00% <60.00%> (ø)
app/app.go 81.38% <20.00%> (+0.56%) ⬆️

@mmsqe mmsqe merged commit a4e82cc into crypto-org-chain:release/v0.22.x-cronos Jun 10, 2024
28 of 31 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants