Problem: event validation can prevent orchestrator nonce to increase (#…

…197)
crypto-org-chain · Jan 26, 2023 · d984b15 · d984b15
1 parent ca80160
commit d984b15
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 3 deletions.
diff --git a/module/x/gravity/keeper/ethereum_event_handler.go b/module/x/gravity/keeper/ethereum_event_handler.go
@@ -120,6 +120,10 @@ func (k Keeper) Handle(ctx sdk.Context, eve types.EthereumEvent) (err error) {
 }
 
 func (k Keeper) verifyERC20DeployedEvent(ctx sdk.Context, event *types.ERC20DeployedEvent) error {
+	if err := sdk.ValidateDenom(event.CosmosDenom); err != nil {
+		return err
+	}
+
 	if existingERC20, exists := k.getCosmosOriginatedERC20(ctx, event.CosmosDenom); exists {
 		return sdkerrors.Wrapf(
 			types.ErrInvalidERC20Event,

diff --git a/module/x/gravity/types/ethereum_event.go b/module/x/gravity/types/ethereum_event.go
@@ -153,9 +153,6 @@ func (e20de *ERC20DeployedEvent) Validate() error {
 	if !common.IsHexAddress(e20de.TokenContract) {
 		return sdkerrors.Wrap(ErrInvalid, "ethereum contract address")
 	}
-	if err := sdk.ValidateDenom(e20de.CosmosDenom); err != nil {
-		return err
-	}
 	return nil
 }