Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

implement the overview page design #69

Closed
dreacot opened this issue Sep 14, 2023 · 2 comments · Fixed by #75
Closed

implement the overview page design #69

dreacot opened this issue Sep 14, 2023 · 2 comments · Fixed by #75
Assignees
Labels
enhancement New feature or request

Comments

@dreacot
Copy link
Member

dreacot commented Sep 14, 2023

CRYPTOPOWER

@xaur
Copy link

xaur commented Oct 30, 2023

Screenshots of the actual implementation in #75 and #115 look a bit different, e.g.

  • Column labels "ID Change" ("1D CHANGE" in the design), "Price" (not "PRICE")
  • numbers are not formatted (no thousand separator, no decimal places)
  • Fonts used for numbers look pale/lower contrast vs the design
  • No subtle shadow box around the tiles
  • Section titles are smaller than in the design

I guess this will be polished in future PRs? Is there an issue for testing the final implementation against the design specs?

@dreacot
Copy link
Member Author

dreacot commented Oct 31, 2023

good catch @xaur , some comments have been resolved, but yes, others would be cleaned up in follow up PRs

Is there an issue for testing the final implementation against the design specs?

not at the moment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: ✅ Done
Development

Successfully merging a pull request may close this issue.

3 participants