New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement overview layout #75
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sirmorrison
force-pushed
the
overviewui
branch
from
September 23, 2023 15:34
2516f3a
to
693dd45
Compare
Sirmorrison
force-pushed
the
overviewui
branch
from
September 23, 2023 15:42
693dd45
to
0117b36
Compare
dreacot
requested changes
Sep 23, 2023
ui/cryptomaterial/icon_gallery.go
Outdated
|
||
i.DCRBackground = NewImage(decredIcons["dcrBkgImage"]) | ||
i.DCRGroupIcon = NewImage(decredIcons["dcrGroupImage"]) | ||
i.LTBackground = NewImage(decredIcons["ltBkgImage"]) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggested change
i.LTBackground = NewImage(decredIcons["ltBkgImage"]) | |
i.LTCBackground = NewImage(decredIcons["ltcBkgImage"]) |
ui/cryptomaterial/icon_gallery.go
Outdated
i.DCRBackground = NewImage(decredIcons["dcrBkgImage"]) | ||
i.DCRGroupIcon = NewImage(decredIcons["dcrGroupImage"]) | ||
i.LTBackground = NewImage(decredIcons["ltBkgImage"]) | ||
i.LTGroupIcon = NewImage(decredIcons["ltGroupImage"]) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggested change
i.LTGroupIcon = NewImage(decredIcons["ltGroupImage"]) | |
i.LTCGroupIcon = NewImage(decredIcons["ltcGroupImage"]) |
This was referenced Sep 24, 2023
dreacot
approved these changes
Sep 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #69
This PR implement the overview layout.
This PR uses dummy data and not real data as a follow up PR will implement the use of real wallet data for on this UI.