Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Doc improvement #7

Closed
wants to merge 2 commits into from
Closed

Conversation

Magnitus-
Copy link
Contributor

Clarification in documentation about requirements for the global Promise variable.

@dougwilson
Copy link
Member

Thank you much!

@dougwilson dougwilson self-assigned this May 9, 2015
@dougwilson dougwilson closed this in d50a1d3 May 9, 2015
@dougwilson
Copy link
Member

Ok, I know I ended up changing the text on you (sorry!), but if you don't like the new text, please let me know and I can update it :)

@Magnitus-
Copy link
Contributor Author

That's fine, this project is your show. Thanks for maintaining it.

I didn't know they supported promises in Node v 0.12, I was under the impression it didn't because it used an older version of V8 and only io.js supported them. Still using v 0.10 so I'd love to have confirmation on that one.

Also, any compelling reason to use bluebird compared to alternatives such as es6-promise or is it mostly a matter of personal taste?

@dougwilson
Copy link
Member

Yes, they do exist on Node.js 0.12 :) I personally do not even use promises, and for everyone I know who does, uses bluebird and I usually see them using bluebird instead of the built-in Promise since it's supposedly much, much faster. This was the only real reason I mentioned it (plus the prior major version of this module would use bluebird).

@Magnitus-
Copy link
Contributor Author

Thanks a bunch for all the info. I'm still in the process of figuring out promises and whether or not I'll use them, but if I do, I guess I'll give bluebird a go.

@dougwilson
Copy link
Member

Yea. I just haven't bitten the Promise bullet just yet :) But I know there are a lot of people who do want to use them.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants