Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIndows-binary for version 0.8.0 shows version "0.7.2" #407

Closed
k9ert opened this issue Sep 19, 2020 · 1 comment
Closed

WIndows-binary for version 0.8.0 shows version "0.7.2" #407

k9ert opened this issue Sep 19, 2020 · 1 comment
Labels
bug Something isn't working help wanted Extra attention is needed

Comments

@k9ert
Copy link
Collaborator

k9ert commented Sep 19, 2020

image

@k9ert k9ert added bug Something isn't working help wanted Extra attention is needed labels Sep 19, 2020
@k9ert
Copy link
Collaborator Author

k9ert commented Sep 19, 2020

It's not clear why this is happening.
As described in the code the version should be overwritable as originally described in this stackoverflow-question.

We're passing that parameter like this:

    - docker run --rm -i -v ${pwd}:/work k9ert/innosetup iscc /work/specter-desktop.iss /DMyAppVersion="$Env:CI_COMMIT_TAG"

I'm quite convinced that this variable is evaluated properly as tested with this code and this gitlab-pipeline-run.

@k9ert k9ert closed this as completed in 91fe223 Sep 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

1 participant