Bugfix - reversing value bytes when calculating totaloutvalue

cryptocoinjs · Feb 11, 2014 · 461e178 · 461e178
1 parent 5daede0
commit 461e178
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 2 deletions.
diff --git a/lib/transaction.js b/lib/transaction.js
@@ -127,7 +127,7 @@ Transaction.prototype.addOutput = function(address, value) {
     if ("number" == typeof value) {
       value = BigInteger(value.toString(), 10);
     }
-    
+
     if ("string" == typeof value) {
       value = BigInteger(value, 10);
     }
@@ -386,7 +386,7 @@ Transaction.prototype.getTotalOutValue = function() {
   var totalValue = BigInteger.ZERO;
   for (var j = 0; j < this.outs.length; j++) {
     var txout = this.outs[j];
-    totalValue = totalValue.add(BigInteger.fromByteArrayUnsigned(txout.value));
+    totalValue = totalValue.add(BigInteger.fromByteArrayUnsigned(txout.value.reverse()));
   }
   return totalValue;
 };

diff --git a/test/transaction.test.js b/test/transaction.test.js
@@ -37,6 +37,16 @@ describe('Transaction ', function() {
     })
   })
 
+  describe(' - Transaction.getTotalOutValue()', function() {
+    it(' > should return the correct value (from LE byte array)', function() {
+      var test = new Transaction()
+      test.addOutput('mvaRDyLUeF4CP7Lu9umbU3FxehyC5nUz3L', '10000000000')
+      test.addOutput('mvaRDyLUeF4CP7Lu9umbU3FxehyC5nUz3L', '20000000000')
+
+      T(test.getTotalOutValue().compareTo(BigInteger('30000000000', 10)) === 0)
+    })
+  })
+
 })
 
 describe('TransactionOut', function() {