Bitcoinjs point code merge + fixes for point decoding #9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also adds curve parameter to test data
|
Coveralls seems to have exploded, but it does mention in the details that the tests did pass. |
jprichardson
added a commit
that referenced
this pull request
Jun 5, 2014
Bitcoinjs point code merge + fixes for point decoding
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request merges all the indentation, formatting and optimizations for
point.jsinto ecurve.To save on re-iterating the changes here, I will be commenting below on any non-obvious changes to the code and will happily answer any questions.
I've also added failing test cases for
decodeFrom, which up until now has been specifically coded to only work for thesecp256k1curve used by Bitcoin.