Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adds Test case that fails on elliptic but works in native code #63

Closed
wants to merge 1 commit into from
Closed

Adds Test case that fails on elliptic but works in native code #63

wants to merge 1 commit into from

Conversation

wanderer
Copy link
Member

No description provided.

@fanatid
Copy link
Member

fanatid commented Jan 18, 2016

It is not elliptic error, we just need extra signature validation

@wanderer
Copy link
Member Author

@fanatid yes I have a fix. But currently I'm messing up git.

@fanatid fanatid mentioned this pull request Jan 18, 2016
Merged
@wanderer
Copy link
Member Author

@fanatid not sure if we should use the solution in #64 or #63 what do you think?

@fanatid
Copy link
Member

fanatid commented Jan 18, 2016

If we want same behavior like bitcoin/secp256k1 we should use #64, but I found that verify also need a fix...

@wanderer wanderer closed this Jan 20, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@wanderer @fanatid