Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Broken builds from ppv-lite86 0.2.11 #48

Closed
jdspdx opened this issue Oct 14, 2021 · 4 comments · Fixed by #52
Closed

Broken builds from ppv-lite86 0.2.11 #48

jdspdx opened this issue Oct 14, 2021 · 4 comments · Fixed by #52

Comments

@jdspdx
Copy link

jdspdx commented Oct 14, 2021

Hello,

Our builds started failing when version 0.2.11 of ppv-lite86 was published to crates.io.

We are seeing failures such as:

    --> /usr/rust/cargo/registry/src/github.com-1ecc6299db9ec823/ppv-lite86-0.2.11/src/x86_64/sse2.rs:1481:28
     |
1481 |                 let ab00 = _mm256_permute2x128_si256::<0x20>(a.x[0], b.x[0]);
     |                            ^^^^^^^^^^^^^^^^^^^^^^^^^-------- help: remove these generics
     |                            |
     |                            expected 0 const arguments
 error[E0061]: this function takes 3 arguments but 2 arguments were supplied
    --> /usr/rust/cargo/registry/src/github.com-1ecc6299db9ec823/ppv-lite86-0.2.11/src/x86_64/sse2.rs:1484:28
     |
1484 |                 let ab11 = _mm256_permute2x128_si256::<0x31>(a.x[1], b.x[1]);
     |                            ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ ------  ------ supplied 2 arguments
     |                            |
     |                            expected 3 arguments

Can you please yank this release? These changes seem to not be compatible with a semver point release.

@jdspdx
Copy link
Author

jdspdx commented Oct 14, 2021

I think this is a problem with our CI environment. Sorry for the false alarm. Researching.

@jdspdx jdspdx closed this as completed Oct 14, 2021
@kazcw
Copy link
Contributor

kazcw commented Oct 14, 2021

No, it's a real bug. I already yanked the version. Thanks for reporting it! I'm still researching the issue.

@jdspdx
Copy link
Author

jdspdx commented Oct 14, 2021

Ah! Thanks!

@kazcw
Copy link
Contributor

kazcw commented Oct 14, 2021

The rust docs aren't currently accurate about the stability of some SIMD fns with const arguments, but I would have caught it if I'd run the MSRV build check. I'll introduce a strict release checklist.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants