Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix node-gyp compiling failure caused by webpack #50

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

jim380
Copy link

@jim380 jim380 commented Mar 24, 2019

Description: Incorrect version of webpack installed causes node-gyp to fail during a rebuild. React requires v4.28.3
Reproduce: git clone then npm i
Fix: add webpack@4.28.3 in package.json

@K-Ho
Copy link
Member

K-Ho commented Mar 25, 2019

Weird.. I only get an error once webpack is added to dependencies -
Screen Shot 2019-03-25 at 3 30 02 PM

I'll take a deeper look tomorrow. Thanks for pointing out though

@jim380
Copy link
Author

jim380 commented Mar 25, 2019 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants