Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Licensing Screen Bypass #293

Closed
Mokura opened this issue Apr 12, 2021 · 9 comments
Closed

Licensing Screen Bypass #293

Mokura opened this issue Apr 12, 2021 · 9 comments
Labels
type:bug Something isn't working
Milestone

Comments

@Mokura
Copy link

Mokura commented Apr 12, 2021

Description

Cryptomator's startup licensing screen can be bypassed.

System Setup

  • Android version: 11
  • Cryptomator version: 1.5.14
  • Cloud type: n/a

Steps to Reproduce

  1. Clean install Cryptomator for Android via non Play Store means (F-Droid, Github Releases, etc...)
  2. Disable .presentation.ui.activity.LicenseCheckActivity and presentation.ui.activity.LicensesActivity through pm or intent firewall rules.
  3. Launch Cryptomator.

Expected Behavior

(Up to your interpretation, honestly. Controlled crash with informational toast or notification?)

Actual Behavior

Cryptomator starts normally.

Reproducibility

Always

Additional Information

I'm not sure how much of an issue this would actually be for the team, I'm mostly posting this as a tinkerer's curiosity. It's basically a shortcut version of doing something similar to building from source with the license checks removed.

Related to #277 possibly?

@Mokura Mokura added the type:bug Something isn't working label Apr 12, 2021
@overheadhunter
Copy link
Member

Thanks for reporting. We'll discuss if this is worth fixing. While funding of this projects depends on license sales, it is still free software and we don't want to invest those funds into preventing modifications. So it all depends on the benefit/cost ratio.

SailReal added a commit that referenced this issue Apr 13, 2021
@SailReal
Copy link
Member

Thanks again for the hint!
We fixed this in c3039f7 and will be published it in the next release soon.

@SailReal SailReal added this to the 1.5.15 milestone Apr 19, 2021
@Mokura
Copy link
Author

Mokura commented Jul 30, 2021

Getting no license prompt on 1.5.18 F-Droid release now, with no external meddling. Is this intentional? I tried checking tbe site, forum, blog etc but I couldn't find any context for a license-free F-Droid release.

@SailReal
Copy link
Member

@Mokura thanks for reaching out!

Which F-Droid-repo do you use where you can install Cryptomator from? I'm only aware of our repo and izzys. Both versions require a license (to be more precise, these repos provide the identical apk). So the question is which repo does offer Cryptomator too? To find this out, can you please open Cryptomator in F-Droid, scroll down to versions and click on the arrow down, there you can see which repo does offer the app as well.
There should be another repo in your list, which would be very interesting for us to know the name of 😉

@Mokura
Copy link
Author

Mokura commented Jul 30, 2021

Looks like I installed from Izzy. (I also use AuroraDroid.) Is there anything I should go hunting for in logcat?

@Mokura
Copy link
Author

Mokura commented Jul 30, 2021

Also here's my repos as shown by Aurora's sync log 🙃

@SailReal
Copy link
Member

What is the first message in the log when you start cryptomator?
App Cryptomator v1.5.18 (2331) "Google Play Edition" started?

When you go in Cryptomator to settings, is the first entry in the list Registered for ...?

@Mokura
Copy link
Author

Mokura commented Jul 30, 2021

I 20210730163225.117 App Cryptomator v1.5.18 (2331) "F-Droid Edition" started on android 11 / API30 using a Pixel 3a

Registered to blank.

@SailReal
Copy link
Member

😳🤔 hmm need to think about it but this is really strange.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants