Actually use the accountId to make Google Drive URLSessions unique

[phil1995]

In cryptomator/ios#342 it has been reported that it's not possible to actually use multiple vaults in parallel with multiple Google Drive accounts.
This is basically because of a typo which resulted in the same background URLSession identifier for all Google Drive accounts. Since running background URLSessions need to be uniquely identified by their identifier all the additionally created ones (for the 2nd Google Drive account, etc.) were broken which resulted in the linked issue.

Summary by CodeRabbit

• Bug Fixes
  • Corrected the construction of a background session identifier in Google Drive integration to include the account ID, enhancing session management.

[coderabbitai]

Walkthrough

The update focuses on refining the Google Drive integration for a cloud storage application. Specifically, it addresses the issue of constructing a unique identifier for background sessions by incorporating the account ID, ensuring a more reliable and personalized connection for each user's data transactions.

Changes

File	Summary
.../GoogleDrive/GoogleDriveCloudProvider.swift	Corrected the construction of a background session identifier to include the account ID.

🐇✨
In the realm of clouds so wide and vast,
A tiny tweak was made, not the first, not the last.
With an ID so unique, a session does bind,
Ensuring your data, with your account, is aligned.
🌟🐾

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

• X
• Mastodon
• Reddit
• LinkedIn

---

Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>.
  • Generate unit-tests for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit tests for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai generate interesting stats about this repository and render them as a table.
  • @coderabbitai show all the console.log statements in this repository.
  • @coderabbitai read src/utils.ts and generate unit tests.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• The JSON schema for the configuration file is available here.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/coderabbit-overrides.v2.json

CodeRabbit Discord Community

Join our Discord Community to get help, request features, and share feedback.

[coderabbitai]

Review Status

Actionable comments generated: 0

Configuration used: CodeRabbit UI

Commits

Files that changed from the base of the PR and between 6e1cd76 and 6b75190.

Files selected for processing (1)

• Sources/CryptomatorCloudAccess/GoogleDrive/GoogleDriveCloudProvider.swift (1 hunks)

Additional comments: 1

Sources/CryptomatorCloudAccess/GoogleDrive/GoogleDriveCloudProvider.swift (1)

• 61-62: The fix to include the account ID in the session identifier string is a crucial step towards resolving the issue with background URLSession identifiers. However, there are a couple of points to consider:

1. Error handling for getAccountID(): Ensure that potential errors from getAccountID() are handled gracefully. It's important to consider what should happen if the account ID cannot be retrieved due to an error.
2. Typo in the session identifier: The identifier string "Crytomator-GoogleDriveSession-\(accountId)-\(bundleId)" contains a typo (Crytomator should be Cryptomator). This typo should be corrected to maintain consistency and avoid confusion.

- "Crytomator-GoogleDriveSession-\(accountId)-\(bundleId)"
+ "Cryptomator-GoogleDriveSession-\(accountId)-\(bundleId)"

Consider adding error handling for the getAccountID() call to ensure the app behaves as expected in case of an error.

[tobihagemann]

Oh my, good catch with that typo! Thank you.

[coderabbitai]

Review Status

Actionable comments generated: 0

Configuration used: CodeRabbit UI

Commits

Files that changed from the base of the PR and between 6b75190 and e85fc6e.

Files selected for processing (1)

• Sources/CryptomatorCloudAccess/GoogleDrive/GoogleDriveCloudProvider.swift (1 hunks)

Files skipped from review as they are similar to previous changes (1)

• Sources/CryptomatorCloudAccess/GoogleDrive/GoogleDriveCloudProvider.swift