Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make shortening treshold adjustable by lib consumers #136

Closed
infeo opened this issue Jul 8, 2022 · 2 comments
Closed

Make shortening treshold adjustable by lib consumers #136

infeo opened this issue Jul 8, 2022 · 2 comments
Milestone

Comments

@infeo
Copy link
Member

infeo commented Jul 8, 2022

WIth Issue #102, the value to restrict the ciphertext filename length (maxNameLength) was splitted into two values: One for the cleartext length and one for the ciphertext length (shorteningThreshold).

The latter was moved for the time being into the internals of the library, making it not adjustable to lib consumers. Since there are use cases where a consumer want to change the default value (220), we should add this to the public api again.

@FusionX9000
Copy link

Is it possible to update shortening threshold and migrate existing vault?

@infeo
Copy link
Member Author

infeo commented Jul 8, 2022

Is it possible to update shortening threshold and migrate existing vault?

No, this is out of scope of this issue.

@infeo infeo closed this as completed in 602f0db Jul 11, 2022
infeo added a commit that referenced this issue Jul 11, 2022
@overheadhunter overheadhunter modified the milestones: 2.5.0, 2.4.3 Oct 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants