Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't rely on ".cryptomator" extension when checking for valid vault directories #141

Closed
ghost opened this issue Feb 9, 2016 · 11 comments
Closed
Assignees
Labels
type:enhancement Improvements on an existing feature
Milestone

Comments

@ghost
Copy link

ghost commented Feb 9, 2016

It is not just enough to have the master key and other files and folders within it?

@overheadhunter
Copy link
Member

On OS X it is a registered bundle type, i.e. it appears to be a "file", even though its a folder. This is just a convenience thing, not a technical necessity ;-)

@ghost
Copy link
Author

ghost commented Feb 9, 2016

Yes, but if I remove the ".cryptomator" extension e.g. on Windows it doesn't recognize my vault. Do you confirm this behavior?

@overheadhunter
Copy link
Member

Yes, the extension is intended to guarantee seamless cross-platform syncing. As said before it is not a technical necessity in order to open a vault (as long as user doesn't mess up the structure of the directory's content), it is rather a convenience feature. If you check out the first few versions of Cryptomator, there was no vault extension.

@ghost
Copy link
Author

ghost commented Feb 9, 2016

Yea, but can we disable this?

@overheadhunter
Copy link
Member

Whats the point?

@ghost
Copy link
Author

ghost commented Feb 9, 2016

I need on Windows and Mac a valut folder without ".cryptomator", just: "Folder". Is this possible now?

@overheadhunter
Copy link
Member

How about this: It should be possible to open a vault regardless of its name, if its structure is intact. This allows people, who know what they are doing, to rename it to whatever they want.

However we will definitely keep the extension by default when creating new vaults, otherwise we get tons of questions by users, who don't understand why some vaults can be opened by doubleclicking and others don't.

@ghost
Copy link
Author

ghost commented Feb 10, 2016

Sorry @overheadhunter. I'm confused. I'm on Windows 8.1.

I create new fault ("MyVault") in a folder on Desktop ("Test folder").

Cryptomator cretaes for me a folder called "MyVault.cryptomator" in my "Test folder" on my Desktop.

Ok. Everything works.

Now I remove the ".cryptomator" extension from the folder "MyVault.cryptomator" and using Cryptomator I select the "+" button and then "Add exsisting vault", then I select the "masterkey.cryptomator" in my (renamed) folder "MyVault" on my "Test folder" on Desktop.

It doesn't work. Cryptomator doesn't add the vault to his list.

If I rename the folder in "MyVault.cryptomator" it works.

@overheadhunter
Copy link
Member

It should be possible to open a vault regardless of its name, if its structure is intact

This was a suggestion, not a description of the current state ;)

@ghost
Copy link
Author

ghost commented Feb 10, 2016

Ah, ok. Thanks.

If it were possible, it would also be interesting to remove the file extension "masterkey.cryptomator". Thanks.

@overheadhunter
Copy link
Member

As said before, the extension will stay by default, otherwise opening bundles is not possible on OS X and we'd get a flood of bug reports. If you want to remove it, you'd be free to do so explicitly as soon as we check the directory structure instead of directory extensions.

@overheadhunter overheadhunter changed the title If I create a new Vault why tha name of the folder needs the ".cryptomator" extension? Don't rely on ".cryptomator" extension when checking for valid vault directories Feb 10, 2016
@overheadhunter overheadhunter added this to the 1.0 milestone Feb 10, 2016
@overheadhunter overheadhunter self-assigned this Feb 10, 2016
@markuskreusch markuskreusch added the type:enhancement Improvements on an existing feature label Feb 26, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:enhancement Improvements on an existing feature
Projects
None yet
Development

No branches or pull requests

2 participants