Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unify design of alerts with template #1430

Closed
3 tasks
infeo opened this issue Nov 23, 2020 · 4 comments · Fixed by #2311
Closed
3 tasks

Unify design of alerts with template #1430

infeo opened this issue Nov 23, 2020 · 4 comments · Fixed by #2311
Labels
good first issue Issues easy to implement or with a narrow scope of changes misc:discussion Requires further conversation to figure out the action steps misc:gui type:enhancement Improvements on an existing feature
Milestone

Comments

@infeo
Copy link
Member

infeo commented Nov 23, 2020

Currently, the application contains different types of alerts but they do not follow the same layout and wording.

I suggest the following template and based on that, check and rework the alerts.
alert_guide

The different types of alerts would be info, warning and error. The info alert has a green icon, the warning alert an orange one and the error alert a red icon.

The tasks to achieve this are:

  • Rename style class label-large to label-extra-large
  • Create new style class label-large with font size 1.25em and font Quicksand Bold
  • Rework user dialogues to the above scheme

Remark

The suggested design is based on https://developer.apple.com/design/human-interface-guidelines/macos/windows-and-views/alerts/ and additionally inspiration is taken from https://uxmovement.com/buttons/5-rules-for-choosing-the-right-words-on-button-labels/

@infeo infeo added type:enhancement Improvements on an existing feature misc:discussion Requires further conversation to figure out the action steps misc:gui labels Nov 23, 2020
@infeo
Copy link
Member Author

infeo commented Nov 23, 2020

@cryptomator What are your thoughts?

@infeo
Copy link
Member Author

infeo commented Nov 23, 2020

I just noticed, the "Apple" design also suggest a help button. In our case this could be link to our docs.

@tobihagemann
Copy link
Member

Thank you, looks great! Would love to have a unified layout for alert dialogs.

  • Is the window title something that we should specify what its purpose is? Is it in most cases the vault name? What about dialogs that are not specific to a vault (maybe set it to the application name)? It shouldn't be redundant to the message.
  • An optional help button is a good idea. Do we already have dialogs that would benefit from that?
  • Does it look better if the icon is top-aligned?

@infeo infeo added the good first issue Issues easy to implement or with a narrow scope of changes label Jan 12, 2021
@stale
Copy link

stale bot commented Apr 16, 2022

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the state:stale Issues without any activity that will be closed automatically label Apr 16, 2022
@overheadhunter overheadhunter removed the state:stale Issues without any activity that will be closed automatically label Apr 18, 2022
Good First Issues automation moved this from To do to Done Jun 30, 2022
infeo added a commit that referenced this issue Jun 30, 2022
@tobihagemann tobihagemann added this to the 1.6.11 milestone Jun 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Issues easy to implement or with a narrow scope of changes misc:discussion Requires further conversation to figure out the action steps misc:gui type:enhancement Improvements on an existing feature
Projects
Development

Successfully merging a pull request may close this issue.

3 participants