Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Observe mounted, unlocked vaults and react to external unmounts #1508

Closed
infeo opened this issue Jan 18, 2021 · 1 comment · Fixed by #1618
Closed

Observe mounted, unlocked vaults and react to external unmounts #1508

infeo opened this issue Jan 18, 2021 · 1 comment · Fixed by #1618
Labels
misc:gui type:feature-request New feature or request
Milestone

Comments

@infeo
Copy link
Member

infeo commented Jan 18, 2021

Summary

If a vault is mounted in the filesystem anymore (due to external events), it should be locked. The gui should react to such events, such that users are not mislead by showing the vault still as unlocked.

Motivation

Unlocking a vault in Cryptomator consists of two steps: Actually unlocking the cryptofilesystem and mounting the filesystem in the OS. While the first step is an internal procedure of the application, the second step interacts with the OS and third parties. As a consequence so created mounts can also be unmounted by external (aka non-Cryptomator) commands/events.

An example is MacOS: A vault mounted via Fuse shows in the volume section of the Finder (default system file manager). Finder allows to eject such volumes, which unmounts them and the content is no longer accessible. In Cryptomator, an ejected vault is still shown as unlocked.

Dokany- and Fuse-based Vaults can be easily monitored, because the main method to mount the vault is blocking, and hence it should be no problem implementing the feature. For WebDAV a research needs to be done, if and how this observe mechanism can be implemented.

Considered Alternatives

Remount the vault - A very bad idea, it could lead to a constant mount and unmount loop. Additionally, maybe the user inititated the unmount.

@infeo
Copy link
Member Author

infeo commented Apr 1, 2021

@infeo infeo added this to the 1.5.x milestone Apr 13, 2021
@infeo infeo added the misc:gui label Apr 14, 2021
Observable Mounts automation moved this from In progress to Done Apr 16, 2021
infeo pushed a commit that referenced this issue Apr 16, 2021
@infeo infeo modified the milestones: 1.5.x, 1.5.15 Apr 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
misc:gui type:feature-request New feature or request
Projects
No open projects
Development

Successfully merging a pull request may close this issue.

1 participant