Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set window size / remember last window size / Fullscreen #1733

Closed
2 tasks done
cy2201 opened this issue Jul 28, 2021 · 4 comments · Fixed by #1761
Closed
2 tasks done

Set window size / remember last window size / Fullscreen #1733

cy2201 opened this issue Jul 28, 2021 · 4 comments · Fixed by #1761
Assignees
Labels
good first issue Issues easy to implement or with a narrow scope of changes misc:gui type:enhancement Improvements on an existing feature type:feature-request New feature or request
Milestone

Comments

@cy2201
Copy link

cy2201 commented Jul 28, 2021

Please agree to the following

Summary

User should be able to config the window size permanently

Motivation

I have a lot of vaults in Cryptomator. After every Windows boot Cryptomator has its fix window size so I maximize the window size by drawing (deutsch: Fenster großziehen) the window. This is okay for the current session but the window / frame size is reset again after a Windows boot.

In the "default" frame size I can't see enough of the folder path and I have to scroll down to see the other vaults in the bottom of the vault list.

It would be a nice if

  • Cryptomator would remember the window size after Windows reboot or
  • we could config this behavior in the settings or
  • we could maximize the Cryptomator window (I mean really maximize like fullscreen browser).

2021-07-28 17_49_58- Alltag  New Issue · cryptomator_cryptomator

Considered Alternatives

No response

Anything else?

No response

@cy2201 cy2201 added the type:feature-request New feature or request label Jul 28, 2021
@overheadhunter overheadhunter added good first issue Issues easy to implement or with a narrow scope of changes misc:gui type:enhancement Improvements on an existing feature labels Jul 28, 2021
@BeyerMart
Copy link
Contributor

The functionality to double-click on the header to change the maximation state should be added as well.
Are you requesting a fullsceen feature like F11 in your browser? I am not sure if that is the best way, to maximize the application. Most other applications also only have the double-click on the header.
The windows key + arrow keys should also work as with other resizable applications. (e. g. Win + down to go from Fullscreen to normal and from normal to minimized)

But to save the size of the reshaped window, we need to store this in the settings. 👍

@BeyerMart BeyerMart self-assigned this Aug 24, 2021
@BeyerMart
Copy link
Contributor

BeyerMart commented Aug 24, 2021

Development takes place in this branch.
Things to pay attention to:

  • make sure that if the position is illegal due to monitor change, it defaults to the main screen
  • save the position and width when moving the window, not just resizing

@BeyerMart
Copy link
Contributor

BeyerMart commented Aug 24, 2021

I got the "browser" fullscreen working with a double click on to the top title bar (this also closes the fullscreen).
image(1080x1920)

This could also be a separate button in between the optional minimize and the close button. I think it should be optional as well.

The other features I talked about like the windows key + arrows are called windows aero. Because of our decision to choose JavaFx, this is not native possible. There are some repositories (a b) implementing this in JavaFx, but it is still not the native snapping of the OS. I don't see the need for this feature in your issue so I will for now not go down this path.

@BeyerMart
Copy link
Contributor

On the topic of removing / rearranging one's display configuration, the window can appear at coordinates where it is not accessible and not even visible. To avoid this I will store the current display configuration in the settings like this:
"displayConfig": "screenId: 0, 1080x1920; screenId: 1 1920x1080; screenId: 2 1920x1080"
The stored coordinates from before will only be loaded if the configuration is still the same as in the settings, otherwise, the window will continue to appear in the middle of the main display.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Issues easy to implement or with a narrow scope of changes misc:gui type:enhancement Improvements on an existing feature type:feature-request New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants