New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Keep modification date and other dates of original file #220

Closed
tobihagemann opened this Issue Apr 6, 2016 · 28 comments

Comments

Projects
None yet
@tobihagemann
Copy link
Member

tobihagemann commented Apr 6, 2016

Not sure if this is possible, but it would be great if the modification date and other dates of the original file can be kept after initial encryption. On the one hand it's just nice-to-have, because original metadata don't get lost. On the other hand it would then be compatible with synchronisation applications (like rsync), because they rely on the modification date.

I know this might have implications on the security, because some metadata would be revealed, but it would increase compatibility and preserve original metadata.

@tobihagemann

This comment has been minimized.

Copy link
Member

tobihagemann commented Apr 6, 2016

Just tested this with a regular WebDAV drive. It seems to me that this is a behavior by Finder on OS X that it doesn't preserve the original dates. This probably can only be solved with an alternative frontend like FUSE as discussed in #206.

@tobihagemann tobihagemann added this to the Backlog milestone Apr 6, 2016

@markuskreusch markuskreusch modified the milestones: Backlog, 1.1 Apr 28, 2016

@overheadhunter overheadhunter modified the milestones: 1.1, 1.x May 10, 2016

@Intuitivi

This comment has been minimized.

Copy link

Intuitivi commented Aug 22, 2016

Hello, I have the same issue. All the dates are reset to the current date once copied to the vault. Is there any workaround for it? Thanks in advance!

@daniel-steinmueller

This comment has been minimized.

Copy link

daniel-steinmueller commented Sep 26, 2016

I'm currently testing cryptomator within a small team.
I've noticed that file modification dates are also changing once a file is just moved from one directory to another. Knowing the original date of a file is essential for us while working on different projects. (system: OSX 10.11.6 / cryptomator 1.2)

It would be great if the original modification date of each file would be preserved and just changed once a file was modified.

@aschei

This comment has been minimized.

Copy link

aschei commented Nov 21, 2016

Same problem here on ubuntu 16.04 using Nautilus. Any comment how we can work around it?

@overheadhunter

This comment has been minimized.

Copy link
Member

overheadhunter commented Nov 22, 2016

Currently we rely on the WebDAV client (i.e. the system-provided mount) to make PROPPATCH requests to set the correct file times. This will change, once we switch to FUSE (Issue #252).

@Didix57

This comment has been minimized.

Copy link

Didix57 commented Nov 26, 2016

Same problem in Windows 7.
I would like to replace Veracrypt with Cryptomator.
I also use HLBU and PureSync. These and some other image-management tools rely on CreateDate and ModificationDate.
I really like the idea of Cryptomator.
However, I will not be able to use it with that flaw.

Actually, for the moment I do not even use a cloud space, just a HDD connected by USB or SATA.
So a network protocol would not be used at all.

@tobihagemann

This comment has been minimized.

Copy link
Member

tobihagemann commented Nov 26, 2016

Is that so? Always thought that Windows wasn't affected by this, because Windows Explorer is doing a PROPPATCH. Could be wrong though, but yeah for Windows we'll switch to Dokany (Issue #207).

@Didix57

This comment has been minimized.

Copy link

Didix57 commented Nov 27, 2016

It is! HLBU refused to work with an error message. Then I copied a file manually to the target directory (on my HDD) and compared the dates with the source. All three date properties of the taget were equal to Now().

I had a look at Issue #207/Dokany. When do you think will that release be ready?

Did I get this right? Cryptomator on Dokany would support HardLinks, too?
That would be fantastic since HLBU preferably works with HardLinks (as the name says :-)

@markuskreusch

This comment has been minimized.

Copy link
Contributor

markuskreusch commented Nov 29, 2016

@Didix57 We currently do not know exactly when #207 will be ready.

Hard- and softlinks are not planned to be supported for now. If it is easy to do and some users really need this we may think about it.

@Didix57

This comment has been minimized.

Copy link

Didix57 commented Nov 29, 2016

Just for my understanding ...

I would expect that a lot of tools are relying on those date attributes (at least all I use).
Therefore not supporting date attributes would drastically reduce the number of users (my guess, based on all the people I know who use the same tools).
Or do I get something wrong?
What tools do you expect (or recommend) that will be used in conjunction with Cryptomator?
And how do these handle questions/problems that are normally resolved by comparing date attributes?

Thanx for supporting!

@tobihagemann

This comment has been minimized.

Copy link
Member

tobihagemann commented Nov 29, 2016

Wait what? The current situation is that WebDAV clients tend to not set the modification dates properly, which is out of Cryptomator's control. That's why we're hoping to fix this particular issue, when the FUSE/Dokany integration is finished. Of course, we'd like to support date attributes then. Hard and soft links are just something that we'll have to see in the future, but that's not what this issue is about. 😄

@Didix57

This comment has been minimized.

Copy link

Didix57 commented Nov 29, 2016

Sorry, my fault - I mixed things up %-) (although I am not drunk :-)

Anyhow, what backup software would you recommend as a replacement for HLBU?
(in conjunction with Cryptometer)

@tobihagemann

This comment has been minimized.

Copy link
Member

tobihagemann commented Nov 29, 2016

Unfortunately, I don't have any recommendation. I haven't looked into backup softwares in detail yet, but I'm also a Mac guy, so I'm really the wrong one to ask for Windows advice/tools. 😅

@ephraimfabian

This comment has been minimized.

Copy link

ephraimfabian commented Feb 4, 2017

@Didix57, sorry if i'm late, I just found out about Cryptomator yesterday. I use SyncBackFree for my backup. I recommend using it for the initial encryption because it actually retains the modified date of my files. This was an issue for me before when I just copy/pasted the files or even used Teracopy.

@lassomagic

This comment has been minimized.

Copy link

lassomagic commented Nov 12, 2017

Just checking in on this as well. Having the modified date and created dates remain in fact is very important to me. But it seems like this is related to the FUSE mount implementation. So just wanted to check in and say +1 for preserving the created/modified timestamps/attributes. It's a big factor for me being unable to use cryptomator as my main cloud encryption tool

This issue is over a year old so it seems to have stalled

@slohmann

This comment has been minimized.

Copy link

slohmann commented Mar 3, 2018

and another +1

@overheadhunter

This comment has been minimized.

Copy link
Member

overheadhunter commented Mar 3, 2018

Will probably be fixed by FUSE support with Cryptomator 1.4.0. A first beta will be available soon.

@overheadhunter

This comment has been minimized.

Copy link
Member

overheadhunter commented Apr 6, 2018

Today we released our first beta of 1.4.0, which brings FUSE support to macOS and Linux.

Please retest this issue with FUSE enabled and report your findings in this thread.


If you experience any new issues, please report them and tell us what software version (including macOS version, involved applications, etc) you're using.

⚠️ This is a beta version! Make backups and don't use this version for production data. ⚠️

@overheadhunter overheadhunter removed this from the 1.x milestone Apr 6, 2018

@aschei

This comment has been minimized.

Copy link

aschei commented Apr 9, 2018

Checked with 1.4.0-beta1 under Ubuntu 16.04, but modification date is NOT preserved. I created a new vault and mounted it using fuse. Then copied an old file using "cp -a " or "cp -p", but nothing is preserved, no ownership, no timestamps, no permissions.
Also: calling chown, chgrp or chmod on files within vault has no effect and is silently ignored (exit code 0). I saw some errors and warnings in the attached cryptomator.log

@overheadhunter

This comment has been minimized.

Copy link
Member

overheadhunter commented Apr 10, 2018

chown is not supported, as the files always belong to the owner of the fuse process. We could add support to override this, using the -ouid= and -ogid= flags.

For chmod support we need to think about how to integrate it properly. For example we can not allow to remove owner read and execute permissions from directories.

But both are a different topic. This issue is about creation/modification/access times, only.

@arngast

This comment has been minimized.

Copy link

arngast commented Aug 20, 2018

Isn't #323 a duplicate of this? I've tested 1.4.0 beta 2 on Suse Leap 15 and the issue still persists. I'm happy to help out.

Right now, backing anything up by syncing into the vault with rsync is useless without correct time stamps.

@StanoRiga

This comment has been minimized.

Copy link

StanoRiga commented Sep 1, 2018

I tested this on Windows 10 with Cryptomator 1.4.0 Beta 2 with Dokany.
Problem still exists. Every Time I just open the file explorer and goto to file directory, every file in it receives a new modification date. The modification date of folders seems to be untouched.
I tested also with FUSE. There the modification date is also not touched. Problem seems solved in this configuration.

@infeo

This comment has been minimized.

Copy link
Member

infeo commented Sep 17, 2018

Good news to everybody: we just fixed the Timestamp-Problem in https://github.com/cryptomator/cryptofs and thus these changes will be included in 1.4.0 version!

@infeo

This comment has been minimized.

Copy link
Member

infeo commented Oct 11, 2018

Fixed with e08c2b7 .

@infeo infeo closed this Oct 11, 2018

@tobihagemann

This comment has been minimized.

Copy link
Member

tobihagemann commented Oct 15, 2018

Please retest with 1.4.0-beta3.

@arngast

This comment has been minimized.

Copy link

arngast commented Oct 15, 2018

Works as intended on OpenSuse Leap 15. Well done and THANKS!

@aschei

This comment has been minimized.

Copy link

aschei commented Oct 15, 2018

Agreed on Ubuntu 16.04 / Mint 18.3. Modification date is preserved, while ownership and permissions are not. Nevertheless: Very important FIX!

@StanoRiga

This comment has been minimized.

Copy link

StanoRiga commented Oct 18, 2018

Tested on Windows10 with Dokany and WebDav and can confirm that the timestamp is untouched now.
Unfortunately, Dokany is painful slow now.
My backup now takes 20 minutes instead of 3 minutes. I can also see a significant delay in accessing the Vault with File Explorer every time I enter a folder
(just for your information)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment