Fonts shipped with app are not used

[infeo]

Please agree to the following

• I have searched existing issues for duplicates
• I agree to follow this project's Code of Conduct

Summary

Cryptomator uses the OpenSans font in its GUI. But the font files are actually not used, but the system default font.

What software is involved?

• Operating System: Windows 11 (possibly all systems)
• Cryptomator: Cryptomator 1.7.3

Volume Type

None

Steps to Reproduce

1. Checkout project and compile with maven
2. Delete all fonts in [projectroot]/src/main/resources/css/
3. Start Cryptomator via IDE with JVM property javafx.verbose=true

Expected Behavior

Open Sans font is used and console does not show warning:

Actual Behavior

Any font but Open Sans is used:

Reproducibility

Always

Relevant Log Output

Mar 28, 2023 3:23:58 PM com.sun.javafx.css.StyleManager loadStylesheetUnPrivileged
INFORMATION: Could not load @font-face font [file:/D:/a/cryptomator/cryptomator/src/main/resources/css/opensans_regular.ttf]
Mar 28, 2023 3:23:58 PM com.sun.javafx.css.StyleManager loadStylesheetUnPrivileged
INFORMATION: Could not load @font-face font [file:/D:/a/cryptomator/cryptomator/src/main/resources/css/opensans_semibold.ttf]
Mar 28, 2023 3:23:58 PM com.sun.javafx.css.StyleManager loadStylesheetUnPrivileged
INFORMATION: Could not load @font-face font [file:/D:/a/cryptomator/cryptomator/src/main/resources/css/opensans_bold.ttf]

Anything else?

No response

[infeo]

Might be related to #2606

[infeo]

This bug is caused by using binary CSS. Executing maven, in the compile phase we have the following plugin execution:

cryptomator/pom.xml

Lines 325 to 338 in 4bb0026

	<execution>
	<id>compile-light-theme</id>
	<phase>compile</phase>
	<goals>
	<goal>java</goal>
	</goals>
	<configuration>
	<mainClass>javafx.graphics/com.sun.javafx.css.parser.Css2Bin</mainClass>
	<arguments>
	<arg>${project.basedir}/src/main/resources/css/light_theme.css</arg>
	<arg>${project.build.outputDirectory}/css/light_theme.bss</arg>
	</arguments>
	</configuration>
	</execution>

This converts our css file into a binary one. The problem is, that during the conversion, relative paths are resolved to absolutes ones (because technically, this conversion is done in two steps: First loading the stylesheet into the javafx model and second write it in binary form). And during the conversion, the absolute path to the font is /path/to/cryptomator-repo/src/main/resources/css/font.ttf.

[infeo]

The performance penalty if we switch back to parsing normal css files is roughly 33%, but in absolute terms it would only be a difference of 20ms (on my machine). Additionally, the stylesheet is loaded once.

Therefore, this enhancement will be removed until upstream the issue is resolved.