Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cryptomator does not use the configured system proxy #2989

Closed
2 tasks done
SailReal opened this issue Jul 5, 2023 · 1 comment
Closed
2 tasks done

Cryptomator does not use the configured system proxy #2989

SailReal opened this issue Jul 5, 2023 · 1 comment
Labels
type:bug Something isn't working
Milestone

Comments

@SailReal
Copy link
Member

SailReal commented Jul 5, 2023

Please agree to the following

Summary

Cryptomator does not use the configured system proxy to connect to the update checker or the Cryptomator hub.

What software is involved?

  • Operating System: All, tested using Linux
  • Cryptomator: 1.9.1

Volume Type

None

Steps to Reproduce

  1. Configure a system proxy
  2. Execute the update check

Expected Behavior

Cryptomator uses the proxy to connect to https://api.cryptomator.org/

Actual Behavior

Cryptomator directly connects to https://api.cryptomator.org/

Reproducibility

Always

Relevant Log Output

No response

Anything else?

If I add -Djava.net.useSystemProxies=true to the launching props, the configured system proxy is used.

@SailReal SailReal added the type:bug Something isn't working label Jul 5, 2023
odouglsantos added a commit to odouglsantos/cryptomator that referenced this issue Jul 8, 2023
odouglsantos added a commit to odouglsantos/cryptomator that referenced this issue Jul 11, 2023
odouglsantos added a commit to odouglsantos/cryptomator that referenced this issue Jul 11, 2023
- better use of the Optional class
- throws IllegalArgumentException is more appropriate when a required object is not present
@infeo infeo closed this as completed in f1d4bd4 Jul 13, 2023
@infeo
Copy link
Member

infeo commented Jul 13, 2023

According to the java docs only on Windows, macOS and GNOME systems the system proxy is used. For Linux environments with other desktop environments, i assume that still no proxy is used.

infeo added a commit to flathub/org.cryptomator.Cryptomator that referenced this issue Jul 13, 2023
@infeo infeo added this to the 1.10.0 milestone Sep 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants