Improve change password workflow

[tobihagemann]

First of all, I want to know: Is it even necessary that the password can only be changed while the vault is locked? What was the design decision behind this back then?

If it's not necessary, should we just remove the restriction in DirectoryListCell.java#L98? And then also enable/disable "Remove from List" from the context menu while the vault is unlocked/locked.

[overheadhunter]

Is it even necessary that the password can only be changed while the vault is locked?

Technically: No, not at all.

What was the design decision behind this back then?

There are two use cases:

1. The user changes the password and unlocks the vault.
2. The user changes the password and doesn't unlock the vault (immediately).

The latter one becomes more likely when changing password is possible while unlocked. Not using the password immediately makes it more likely to forget it. Thats all.

In any case it will be possible to restore the masterkey backup file, if unlock with the new password "doesn't work" (even though the user is 100% certain he entered the correct password^^).

[stale]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.