Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Crashes with 1.4.11 #908

Closed
dejury opened this issue Jun 12, 2019 · 7 comments
Closed

Crashes with 1.4.11 #908

dejury opened this issue Jun 12, 2019 · 7 comments
Labels
type:bug Something isn't working

Comments

@dejury
Copy link

dejury commented Jun 12, 2019

Description

Today i updated from 1.4.9 to 1.4.11. Since the update, my decrypted disk crashes and afterwards i need to mount the disk again. After a while it crashes again. On 1.4.9 everything worked.

Reboot didn't help, so seems to be a problem in the application.

System Setup

  • Operating system and version: Windows 10 Home, 10.0.18362
  • Cryptomator version: 1.4.11
  • Drive: Dokany

Steps to Reproduce

  1. Mount a disk
  2. Do some actions on the disk
  3. Disk crashes

Expected Behavior

No crashes at all ;)

Actual Behavior

Crashes.

Reproducibility

Always

Additional Information

See attached log

log.txt

@dejury dejury added the type:bug Something isn't working label Jun 12, 2019
@dejury
Copy link
Author

dejury commented Jun 12, 2019

Seems to be related to #888. Didn't see this stack trace in that issue, so maybe it helps.

@dejury
Copy link
Author

dejury commented Jun 12, 2019

Upgrading Dokany from 1.2.0.1000 to 1.2.2.1000 resolved the problem. Is it maybe better to update Dokany too when updating Cryptomator?

@tobihagemann
Copy link
Member

Thank you for your bug report! Dokany as a dependency is making everything so tricky. We're following the instructions/suggestions from here: https://github.com/dokan-dev/dokany/wiki/How-to-package-your-application-with-Dokan

The Dokan driver can not be installed as an upgrade becausee it requires an intermittent reboot for the uninstall of an existing version.

This is probably the saddest thing ever because we can't give Cryptomator users a convenient way to update Dokany once it's installed on their system.

BUT since it is possible that Dokan library will be updated by another Dokan application, the update might break link dependency to your application. Therefore it is highly recommended embedding the dokan1.dll in your application folder. Doing this will retain compatibility of your application with all MAJOR versions equal to the library you embed.

We actually updated the dokan1.dll file recently and maybe this caused the problem... but... why? Shouldn't dokan1.dll work with any installed Dokany driver with major version 1?

@Liryna Any ideas on this one? Maybe we were just unlucky with the latest version of dokan1.dll (version 1.2.2.1000)?

@Liryna
Copy link

Liryna commented Jun 12, 2019

Just got the same report here https://groups.google.com/forum/#!topic/dokan/d-47ztI78Y8

In the newest library we are using a new keepalive mechanism that prevents to have zombies drive in case the user fs crash. Currently an older library work with the newest kernel driver. Here the keepalive fail to establish since kernel does not have the feature in the install version. We maybe had to have a fallback to older keepalive mechanism 😢 will look to add it for next release. I can understand updating the driver (rebooting) is not the best UX but there is not much we can do for now dokan-dev/dokany#669

@tobihagemann
Copy link
Member

Thank you for the info, @Liryna! All right, we'll repackage our installer with an older version of Dokany in the meantime.

tobihagemann added a commit to cryptomator/cryptomator-win that referenced this issue Jun 12, 2019
@tobihagemann
Copy link
Member

@Liryna
Copy link

Liryna commented Jun 22, 2019

Fix is ready and will be ship next release 👍
dokan-dev/dokany#804

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants