1.4.13: Vault locking not fully recognized

[RiseT]

Description

When locking a vault, the corresponding drive does indeed disappear from Windows Explorer, but Cryptomator does seem to think it's still open as reflected by its GUI. The prior Cryptomator version (1.4.12) was behaving correctly.

System Setup

• Operating system and version: Windows 10
• Cryptomator version: 1.4.13
• Drive: Dokany

Steps to Reproduce

1. Unlock a vault
2. Lock a vault

Expected Behavior

Crytomator's GUI should show a locked vault, i. e. lock icon, lock button, etc should change correspondingly

Actual Behavior

No GUI change at all visible vs. unlocked vault. When trying to "lock" the already locked vault by pressing the lock button again, an error message is shown (German: "Trennen des Laufwerks fehlgeschlagen")

Reproducibility

Tried it a couple of times with rebooting in between with the same result

Additional Information

Error in log:

13:58:29.607 [JavaFX Application Thread] ERROR org.cryptomator.ui.util.Tasks - Unhandled exception
java.lang.Error: Invalid memory access
	at com.dokany.java.NativeMethods.DokanUnmount(Native Method)
	at com.dokany.java.DokanyDriver.stop(DokanyDriver.java:97)
	at com.dokany.java.DokanyDriver.shutdown(DokanyDriver.java:87)
	at org.cryptomator.frontend.dokany.Mount.close(Mount.java:66)
	at org.cryptomator.ui.model.DokanyVolume.unmount(DokanyVolume.java:99)

Full log:
https://gist.github.com/RiseT/3a6cc0a0449dac2f1f4c48a8161fb773

[abysso2]

Hi,
i have seen the same behaviour with Cryptomator 1.4.13 on Windows 10 (x64) 1903 and Dokany 1.2.2.1000 - so i upgraded to Dokany 1.3.0.1000 just to give it a try (https://github.com/dokan-dev/dokany/blob/master/CHANGELOG.md) and since then, i can not reproduce the issue.

Cloud you please test this one?

Regards,
A.

[overheadhunter]

Interesting. We really need Dokany to be able to upgrade properly, so we can distribute the latest version with Cryptomator without requiring the user to uninstall Dokany manually before.

[mcgege]

Hi,
i have seen the same behaviour with Cryptomator 1.4.13 on Windows 10 (x64) 1903 and Dokany 1.2.2.1000 - so i upgraded to Dokany 1.3.0.1000 just to give it a try (https://github.com/dokan-dev/dokany/blob/master/CHANGELOG.md) and since then, i can not reproduce the issue.

Same here, Dokany 1.3.0.1000 solves this issue.

[RiseT]

Thanks for the info. I guess this is/has been the issue (from Dokany's change log):

Library - Fix DokanUnmount possible oob memory

[dejury]

I can confirm upgrading to Dokany 1.3.0.1000 solves the issue.

Though, before I upgraded, the locking of the Vault only "did not work" when I already browsed within the vault. If I tried to lock a Vault which I did not browse (only opened the root), the locking worked as expected.

This makes me think this is maybe an issue that can be fixed within the code of Cryptomator.

[stale]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

[t0ma5]

i upgraded to Dokany 1.3.0.1000 just to give it a try (https://github.com/dokan-dev/dokany/blob/master/CHANGELOG.md) and since then, i can not reproduce the issue.

Thanks! it worked for me. Link to Dokany releases: https://github.com/dokan-dev/dokany/releases